Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recently adjusted container bulk localisation strings #11845

Merged

Conversation

j-bs
Copy link
Contributor

@j-bs j-bs commented Nov 28, 2023

This was just a minor error that was missed during the item bulk refactor: the modified localisation strings don't have the nested Bulk level.

@stwlam
Copy link
Collaborator

stwlam commented Nov 28, 2023

Instead of changing the template, change en.json to match.

This was just a minor error that was missed during the item bulk refactor
@j-bs j-bs force-pushed the fix-backpack-template-ref-to-localisations branch from 836add9 to 71c87b2 Compare November 28, 2023 23:53
@j-bs j-bs changed the title Fix reference to localisation strings in backpack template Fix recently adjusted container bulk localisation strings Nov 28, 2023
@j-bs
Copy link
Contributor Author

j-bs commented Nov 28, 2023

Done, wasn't sure which was preferred.

@stwlam stwlam merged commit 230694f into foundryvtt:master Nov 29, 2023
1 check passed
@stwlam stwlam added the pr: data update Updates to existing actors and items label Nov 29, 2023
@j-bs j-bs deleted the fix-backpack-template-ref-to-localisations branch November 29, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants