Fix labels and slugs in Finisher migration (#14009)

foundryvtt · Mar 1, 2024 · f83778d · f83778d
1 parent 4f88da9
commit f83778d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/packs/iconics/jirelle-level-1.json b/packs/iconics/jirelle-level-1.json
@@ -2390,8 +2390,8 @@
  "option": "finisher",
  "suboptions": [
  {
- "label": "PF2E.SpecificRule.Swashbuckler.Finisher.ConfidentFinisher",
- "value": "confident-finisher"
+ "label": "PF2E.SpecificRule.Swashbuckler.Finisher.Confident",
+ "value": "confident"
  }
  ],
  "toggleable": true

diff --git a/packs/iconics/jirelle-level-5.json b/packs/iconics/jirelle-level-5.json
@@ -1525,8 +1525,8 @@
  "option": "finisher",
  "suboptions": [
  {
- "label": "PF2E.SpecificRule.Swashbuckler.Finisher.UnbalancingFinisher",
- "value": "unbalancing-finisher"
+ "label": "PF2E.SpecificRule.Swashbuckler.Finisher.Unbalancing",
+ "value": "unbalancing"
  }
  ],
  "toggleable": true
@@ -3195,8 +3195,8 @@
  "option": "finisher",
  "suboptions": [
  {
- "label": "PF2E.SpecificRule.Swashbuckler.Finisher.ConfidentFinisher",
- "value": "confident-finisher"
+ "label": "PF2E.SpecificRule.Swashbuckler.Finisher.Confident",
+ "value": "confident"
  }
  ],
  "toggleable": true

diff --git a/packs/paizo-pregens/zathri.json b/packs/paizo-pregens/zathri.json
@@ -471,8 +471,8 @@
  "option": "finisher",
  "suboptions": [
  {
- "label": "PF2E.SpecificRule.Swashbuckler.Finisher.ImpalingFinisher",
- "value": "impaling-finisher"
+ "label": "PF2E.SpecificRule.Swashbuckler.Finisher.Impaling",
+ "value": "impaling"
  }
  ],
  "toggleable": true
@@ -3014,8 +3014,8 @@
  "option": "finisher",
  "suboptions": [
  {
- "label": "PF2E.SpecificRule.Swashbuckler.Finisher.ConfidentFinisher",
- "value": "confident-finisher"
+ "label": "PF2E.SpecificRule.Swashbuckler.Finisher.Confident",
+ "value": "confident"
  }
  ],
  "toggleable": true

diff --git a/src/module/migration/migrations/922-swashbuckler-finisher-suboptions.ts b/src/module/migration/migrations/922-swashbuckler-finisher-suboptions.ts
@@ -43,7 +43,7 @@ export class Migration922SwashbucklerFinishers extends MigrationBase {
  }
 
  #buildRule(slug: string) {
- const name = sluggify(slug, { camel: "bactrian" });
+ const name = sluggify(slug, { camel: "bactrian" }).replace("Finisher", "");
 
  const rule = {
  disabledIf: [
@@ -60,7 +60,7 @@ export class Migration922SwashbucklerFinishers extends MigrationBase {
  suboptions: [
  {
  label: `PF2E.SpecificRule.Swashbuckler.Finisher.${name}`,
- value: `${slug}`,
+ value: `${slug.replace("-finisher", "")}`,
  },
  ],
  toggleable: true,