Add Underwater weapon property rune (#9271)

foundryvtt · Aug 12, 2023 · e478153 · e478153
1 parent 5cb35e7
commit e478153
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 7 deletions.
diff --git a/packs/equipment/lionfish-spear-greater.json b/packs/equipment/lionfish-spear-greater.json
@@ -53,10 +53,10 @@
  }
  },
  "propertyRune1": {
- "value": "wounding"
+ "value": "underwater"
  },
  "propertyRune2": {
- "value": null
+ "value": "wounding"
  },
  "propertyRune3": {
  "value": null

diff --git a/packs/equipment/lionfish-spear.json b/packs/equipment/lionfish-spear.json
@@ -53,10 +53,10 @@
  }
  },
  "propertyRune1": {
- "value": "wounding"
+ "value": "underwater"
  },
  "propertyRune2": {
- "value": null
+ "value": "wounding"
  },
  "propertyRune3": {
  "value": null

diff --git a/packs/other-effects/effect-aquatic-combat.json b/packs/other-effects/effect-aquatic-combat.json
@@ -19,7 +19,10 @@
  {
  "key": "Note",
  "predicate": [
- "fire"
+ "fire",
+ {
+ "not": "item:rune:property:underwater"
+ }
  ],
  "selector": "all",
  "text": "PF2E.SpecificRule.AquaticCombat.FireNote"
@@ -44,6 +47,9 @@
  "item:category:unarmed",
  "self:type:npc"
  ]
+ },
+ {
+ "not": "item:rune:property:underwater"
  }
  ],
  "selector": "melee-attack-roll",
@@ -61,7 +67,10 @@
  {
  "definition": [
  "item:ranged",
- "item:damage:type:piercing"
+ "item:damage:type:piercing",
+ {
+ "not": "item:rune:property:underwater"
+ }
  ],
  "key": "AdjustStrike",
  "mode": "multiply",
@@ -71,7 +80,10 @@
  {
  "key": "Note",
  "predicate": [
- "item:ranged"
+ "item:ranged",
+ {
+ "not": "item:rune:property:underwater"
+ }
  ],
  "selector": "attack",
  "text": "PF2E.SpecificRule.AquaticCombat.RangedNote"

diff --git a/src/module/item/physical/runes.ts b/src/module/item/physical/runes.ts
@@ -1171,6 +1171,14 @@ export const WEAPON_PROPERTY_RUNES: Record<WeaponPropertyRuneType, WeaponPropert
  slug: "thundering",
  traits: ["evocation", "magical", "sonic"],
  },
+ underwater: {
+ level: 3,
+ name: "PF2E.WeaponPropertyRune.underwater.Name",
+ price: 50,
+ rarity: "common",
+ slug: "underwater",
+ traits: ["magical", "water"],
+ },
  unholy: {
  damage: {
  dice: [

diff --git a/src/module/item/weapon/values.ts b/src/module/item/weapon/values.ts
@@ -86,6 +86,7 @@ const WEAPON_PROPERTY_RUNE_TYPES = new Set([
  "spellStoring",
  "swarming",
  "thundering",
+ "underwater",
  "unholy",
  "vorpal",
  "wounding",

diff --git a/static/lang/en.json b/static/lang/en.json
@@ -5204,6 +5204,9 @@
  "criticalSuccess": "On a critical hit, the target has to succeed at a @Check[type:fortitude|dc:24|name:Thundering Rune] save or be @UUID[Compendium.pf2e.conditionitems.Item.9PR9y0bi4JPKnHPR]{Deafened} for 1 minute (or 1 hour on a critical failure)."
  }
  },
+ "underwater": {
+ "Name": "Underwater"
+ },
  "unholy": {
  "Name": "Unholy",
  "Note": {