improvement: cast wallet import / --account option #5551
Merged
+224
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Aug 7, 2023
|
Thanks for the feedback, now addressed @mattsse. |
Evalir
requested changes
Aug 7, 2023
cli/src/cmd/cast/wallet/mod.rs
Outdated
| None | ||
| } | ||
| } | ||
| Err(e) => Some(Err(eyre::Report::from(e))), |
There was a problem hiding this comment.
Updated. Is it good like this?
|
@Evalir addressed your feedback but left some follow-up questions |
2 tasks
|
OMG LETS GOOOOO RAFAEL!!!!! |
mattsse
approved these changes
Aug 10, 2023
Evalir
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Intro
Most of the motivation comes from these issues:
Issue#1869
Issue#3818
Big shoutout to @PatrickAlphaC for the proposed API
Summary
If you want to use your own private keys, you are going to either: expose them on the terminal or type them every time through
--interactive. A great alternative would be to use keystores, but these are limited to random ones created throughcast wallet new PATH.It would also be good to be able to set some env vars and then forget about that, while also maintaining a high security standard.
Solution
New Features
cast wallet import
Encrypt private keys through JSON keystores into a default directory (
~/.foundry/keystores) that can later be accessed through their assigned names when usingcast send,forge createorforge script.Which then prompts the user for a password, and encrypts it locally on the default directory.
cast wallet list
Have a command to list stored keystores in the default directory
Changes to the codebase
Extraction of Wallet's Raw Opts
I had to extract the raw options from the
opts/wallet:Walletstruct. This is cause I wanted to reduce the amount of code duplication, so now I could use that in the use ofcast wallet import, which really only cares about the handling of mnemonics and private keys.Adding of --account option for MultiWallet and Wallet
In order to leverage the imported keystores by name, I had to create a new option:
--accountorETH_KEYSTORE_ACCOUNT. This enables to simplify the following command:into the smaller / simpler: