play store/fdroid flavors added #1878

neel1998 · 2019-07-17T18:59:33Z

Fixes #1739

Changes: play store/fdroid flavors added

Screenshot/s for the changes:

Google Map Demo

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
I have reformatted code in every file included in this PR [CTRL+ALT+L]
My code does not contain any extra lines or extra spaces
I have requested reviews from other members

APK for testing:
app-fdroid-debug2.zip
app-playstore-debug2.zip

CloudyPadmal · 2019-07-18T05:33:28Z

app/build.gradle

@@ -17,11 +17,13 @@ android {
 debug {
 versionNameSuffix "Version: "
 resValue "string", "version", "${versionNameSuffix}${defaultConfig.versionName}"
+ resValue "string", "google_maps_key", "AIzaSyBFvrqI8_J108WntI7surDGqCUcd1RbHPQ"


Refer this from a resource file

I couldn't find proper way to access string resource in gradle file . So as suggested in this article https://medium.com/code-better/hiding-api-keys-from-your-android-repository-b23f5598b906 i am adding key to gradle.properties and then accessing it in build.gradle.

CloudyPadmal · 2019-07-18T05:33:55Z

app/build.gradle

@@ -70,12 +82,13 @@ dependencies {
 implementation 'com.github.Triggertrap:SeekArc:v1.1'

 implementation "com.jakewharton:butterknife:$rootProject.butterKnifeVersion"
+ playstoreImplementation 'com.google.android.gms:play-services-maps:16.0.0'


Set versions like the rest of libraries here

CloudyPadmal · 2019-07-18T05:34:29Z

app/src/fdroid/java/io/pslab/MapsActivity.java

@@ -1,4 +1,4 @@
-package io.pslab.activity;


Why is this activity moved out from activity package and taken out? Revert.

app/src/main/AndroidManifest.xml

CloudyPadmal · 2019-07-18T06:03:12Z

I checked both the APKs. I couldn't open the map view in playstore flavor and it crashes with this log

2019-07-18 11:30:34.472 1345-1378/io.pslab E/AndroidRuntime: FATAL EXCEPTION: Thread-4
    Process: io.pslab, PID: 1345
    java.lang.NoClassDefFoundError: Failed resolution of: Lorg/apache/http/ProtocolVersion;
        at gw.b(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):3)
        at gt.a(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):3)
        at gv.a(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):14)
        at com.google.maps.api.android.lib6.drd.ak.a(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):6)
        at fx.a(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):22)
        at fx.run(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):8)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "org.apache.http.ProtocolVersion" on path: DexPathList[[zip file "/data/user_de/0/com.google.android.gms/app_chimera/m/0000000d/MapsDynamite.apk"],nativeLibraryDirectories=[/data/user_de/0/com.google.android.gms/app_chimera/m/0000000d/MapsDynamite.apk!/lib/x86, /system/lib]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:134)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        at ab.loadClass(:com.google.android.gms.dynamite_dynamiteloader@[email protected] (100700-253824076):4)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        at gw.b(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):3) 
        at gt.a(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):3) 
        at gv.a(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):14) 
        at com.google.maps.api.android.lib6.drd.ak.a(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):6) 
        at fx.a(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):22) 
        at fx.run(:com.google.android.gms.dynamite_mapsdynamite@[email protected] (100700-253824076):8)

In fdroid flavor, open street map is not shown, just the brownish grid with no map. @ho-dor @AakashMallik @cweitat can you try the apks and see?

neel1998 · 2019-07-18T06:09:21Z

@CloudyPadmal i uninstalled the app and reinstalled using the playstore apk, and it worked fine with me. About the OSM , i haven't modified the code of the OSM, it was not showing map before as well I think, so I thought something was wrong with OSM itself. I will check once though.

cweitat · 2019-07-18T06:24:28Z

Doesn't crash on my phone. The only problem is the OSM does not load.
@neel1998 OSM used to work

neel1998 · 2019-07-18T06:26:36Z

@CloudyPadmal i think I found the problem with the crash. I think you are using Android P. It is a famous issue with Android P and google has provided a solution. I will send you apk in few minutes. Hopefully it will work

neel1998 · 2019-07-18T06:27:51Z

Doesn't crash on my phone. The only problem is the OSM does not load.
@neel1998 OSM used to work

I will look into OSM. Thanks

neel1998 · 2019-07-18T06:34:02Z

@CloudyPadmal try this apk.
app-playstore-debug2.zip

neel1998 · 2019-07-18T07:27:07Z

@cweitat @CloudyPadmal check this Fdroid apk. It's working now. Apparently OSM library has made some changes in their provider and we need to set one config constant manually to get it working like before. Let me know if it works fine. Then i will push this change with rest of the requested changes. Thanks
app-fdroid-debug2.zip

neel1998 · 2019-07-18T13:19:33Z

@cweitat @CloudyPadmal i have made all the possible of the requested changes, i have also updated the apk in the PR message. Please check. Thanks

cweitat approved these changes Jul 18, 2019

View reviewed changes

CloudyPadmal requested changes Jul 18, 2019

View reviewed changes

playstore/fdroid flavors added

662bc33

neel1998 force-pushed the OSM_google_map branch from bb0aa4b to 662bc33 Compare July 18, 2019 12:48

cweitat approved these changes Jul 18, 2019

View reviewed changes

CloudyPadmal approved these changes Jul 19, 2019

View reviewed changes

CloudyPadmal merged commit d20bdfa into fossasia:development Jul 19, 2019

neel1998 added a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019

playstore/fdroid flavors added (fossasia#1878)

7387a34

neel1998 deleted the OSM_google_map branch August 27, 2019 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

play store/fdroid flavors added #1878

play store/fdroid flavors added #1878

neel1998 commented Jul 17, 2019 •

edited

Loading

CloudyPadmal Jul 18, 2019

neel1998 Jul 18, 2019

CloudyPadmal Jul 18, 2019

CloudyPadmal Jul 18, 2019

CloudyPadmal commented Jul 18, 2019

neel1998 commented Jul 18, 2019

cweitat commented Jul 18, 2019 •

edited

Loading

neel1998 commented Jul 18, 2019

neel1998 commented Jul 18, 2019

neel1998 commented Jul 18, 2019

neel1998 commented Jul 18, 2019

neel1998 commented Jul 18, 2019

play store/fdroid flavors added #1878

play store/fdroid flavors added #1878

Conversation

neel1998 commented Jul 17, 2019 • edited Loading

Google Map Demo

CloudyPadmal Jul 18, 2019

Choose a reason for hiding this comment

neel1998 Jul 18, 2019

Choose a reason for hiding this comment

CloudyPadmal Jul 18, 2019

Choose a reason for hiding this comment

CloudyPadmal Jul 18, 2019

Choose a reason for hiding this comment

CloudyPadmal commented Jul 18, 2019

neel1998 commented Jul 18, 2019

cweitat commented Jul 18, 2019 • edited Loading

neel1998 commented Jul 18, 2019

neel1998 commented Jul 18, 2019

neel1998 commented Jul 18, 2019

neel1998 commented Jul 18, 2019

neel1998 commented Jul 18, 2019

neel1998 commented Jul 17, 2019 •

edited

Loading

cweitat commented Jul 18, 2019 •

edited

Loading