Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CMake project from stdlib to fortran_stdlib #290

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jan 6, 2021

Part 2/3 for #287, status: optional. If you do not like this approach we can do #287 without it.

Changes:

  • rename CMake project from stdlib to fortran_stdlib
  • reuse the PROJECT_NAME CMake variable instead of using fortran_stdlib directly

Reasoning:

  • exported CMake targets usually match the project name (fortran_stdlib seems less likely to clash with something compared to stdlib)
  • allows to easily use PROJECT_NAME to write reusable/transferable CMake code for different projects (interesting for fpm generated CMake files as well)
  • PROJECT_NAME is accessible in configure_file and can be used to create more general template files

- match project name with name of produced library target
- allows convenient reusing of the PROJECT_NAME variable in CMake and configure_file commands
- might reduce risk for typos (PROJECT_NAME is highlighted, fortran_stdlib not)
@awvwgk awvwgk merged commit f4f6045 into fortran-lang:master Jan 15, 2021
@awvwgk awvwgk deleted the fortran_stdlib branch January 15, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants