Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DelayedErrorReader to avoid the case where we get both EOF and some data in a single read #974

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

ldemailly
Copy link
Member

fixes #972 but a bit messy way/too generic

…some data in a single read. fixes #972 but a bit messy way/too generic
@ldemailly
Copy link
Member Author

https://badsslcom is having some issues causing test failures

@ldemailly
Copy link
Member Author

tests are more stable with netgo build tag

Copy link

@tejaspbajaj tejaspbajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@ldemailly ldemailly merged commit 7074435 into master Sep 13, 2024
8 checks passed
@ldemailly ldemailly deleted the eof_handling branch September 13, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EOF error for non keep alive HTTP 1.1 requests
2 participants