Documented how to use ember-intl #4458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
commented
Jun 4, 2024
| @@ -33,7 +33,7 @@ export default { | |||
| label: 'API References', | |||
| position: 'left', | |||
| activeBaseRegex: | |||
| 'docs/(vue-intl|intl|react-intl|intl-messageformat|icu-messageformat-parser)', | |||
| 'docs/(vue-intl|intl|ember-intl|react-intl|intl-messageformat|icu-messageformat-parser)', | |||
There was a problem hiding this comment.
I wasn't sure what activeBaseRegex does. I updated the line because it had mentioned vue-intl and react-intl.
ijlee2
force-pushed
the
document-ember-intl
branch
from
87bed30
to
b8690ec
Compare
ijlee2
force-pushed
the
document-ember-intl
branch
from
b8690ec
to
f8499ce
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ijlee2
force-pushed
the
document-ember-intl
branch
from
f8499ce
to
f3542fd
Compare
|
Hi, @longlho. Would you be interested in this PR getting merged, so that the documentation provides more information about using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, everyone. In ember-intl/ember-intl#1801, @longlho had reached out to see if it might be possible to move the
ember-intlpackage to this repo. I had declined the offer and proposed, as an alternative, a larger mention ofember-intlin theformatjswebsite, so that people from the wider JS community may learn how to set up and useember-intl.In case you (and possibly other maintainers) are still open to this idea of updating the
formatjsdocumentation, I created this pull request so that we can begin a conversation. Thanks in advance.Preview: