[pull] master from carp-lang:master #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* refactor: project configuration get/set parity
This commit refactors our handling of project configuration
getters/setters in hopes of making it easier to ensure fields that have
getters have setters and vice versa, and to ensure field keys are
consistent across the Project.config and get-config commands.
This commit also makes these commands return XObjs for all calls,
instead of coercing certain things into strings and also adds getters
for fields that previously lacked them, e.g.:
(Project.get-config "libflags")
=> ("-lm")
I've maintained parity with existing behaviors to avoid breaking
changes, thus, this works as it did before this commit:
(Project.config "libflags" "-lfoo")
(Project.get-config "libflags")
=> ("-lm" "-lfoo")
though it could now arguably take a list as an argument to permit
complete one-liner replacements; one could still add a single flag and
the interface would be more functional:
(Project.config "libflags"
(cons "-lfoo" (Project.get-config "libflags")))
=> ("-lm" "-lfoo")
(Project.config "libflags" ("-lbar" "-qux"))
=> ("-lbar" "-lqux")
But, again, I've retained the old behavior to avoid breaking existing
builds.
This also fixes a small issue where by setting the file path print
length to "full" still resulted in the "short" printing scheme.
* fix: small typo fix in config field error messages
* fix: restore old names for cflag and libflag config fields
I accidentally pluralized these field keys, which broke some existing
tests. This commit fixes that issue by restoring the original names.
* fix: backwards compatibility for configuration fields
Another small fix to ensure we retain backwards compatibility with
existing code after recent configuration handling changes: pkg-config
and load-stack fields should return array values, not lists.
* refactor: move project configuration get/setters into a new module
Moves the project configuration frontend code into its own module to
avoid cyclic deps between Project and Obj and keep the Obj module
clean.
I've also removed some noisy comments about "internal only"
project configuration fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )