Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waterfall & some sound effects. #6

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Add waterfall & some sound effects. #6

merged 1 commit into from
Dec 10, 2020

Conversation

knightofiam
Copy link
Member

  • FEATURES:

    • ENVIRONMENT: Add animated waterfall (rough draft) with positional
      audio. It's really loud if you're standing under it, but gets
      quieter pretty quickly as you walk away.
    • SOUND: Add outdoor summer ambience.
    • SOUND: Add cliff scraping sound that modulates according to vertical
      velocity (i.e., higher-pitched when falling faster & scraping,
      lower-pitched when falling slower & scraping).
    • DEBUGGING: Add pressing 'R' key respawns at top of cliffs, mainly
      for testing.
    • DEBUGGING: Add falling stats to player debugging text (press 'T' to
      show/hide debugging text).
  • BUGFIXES:

    • CLIMBING: Stop cliff scraping when you reach the ground.
    • CLIMBING: Don't allow going into horizontal climbing state from
      jumping state.
    • CLIMBING: Climbing preparation time now resets if you let go of the
      up arrow before beginning to climb up. This is so after facing the
      cliffs for a while, you can't just skip the preparation time when
      you decide to start climbing. You must always have the delay between
      pressing the up arrow while facing the cliffs and the actual start
      of climbing, and this requires the up arrow key to be held down.
    • ANIMATION: Enable pixel snap to prevent waterfall sprite sections
      tearing.
    • ANIMATION: Enable forcing 60 FPS for consistent animation & game
      speed, and to simplify debugging.
  • REFACTORING:

    • TOOLS: Make some utility methods in Tools class publicly accessible
      (they were mistakenly private after refactoring them out of
      Player.cs.)
    • PLAYER: Remove unnecessary TODO comment about removing unused
      _isClimbingRight. Just leave it for now, since it should be paired
      with _isClimbingLeft.

- FEATURES:
  - ENVIRONMENT: Add animated waterfall (rough draft) with positional
    audio. It's really loud if you're standing under it, but gets
    quieter pretty quickly as you walk away.
  - SOUND: Add outdoor summer ambience.
  - SOUND: Add cliff scraping sound that modulates according to vertical
    velocity (i.e., higher-pitched when falling faster & scraping,
    lower-pitched when falling slower & scraping).
  - DEBUGGING: Add pressing 'R' key respawns at top of cliffs, mainly
    for testing.
  - DEBUGGING: Add falling stats to player debugging text (press 'T' to
    show/hide debugging text).

- BUGFIXES:
  - CLIMBING: Stop cliff scraping when you reach the ground.
  - CLIMBING: Don't allow going into horizontal climbing state from
    jumping state.
  - CLIMBING: Climbing preparation time now resets if you let go of the
    up arrow before beginning to climb up. This is so after facing the
    cliffs for a while, you can't just skip the preparation time when
    you decide to start climbing. You must always have the delay between
    pressing the up arrow while facing the cliffs and the actual start
    of climbing, and this requires the up arrow key to be held down.
  - ANIMATION: Enable pixel snap to prevent waterfall sprite sections
    tearing.
  - ANIMATION: Enable forcing 60 FPS for consistent animation & game
    speed, and to simplify debugging.

- REFACTORING:
  - TOOLS: Make some utility methods in Tools class publicly accessible
    (they were mistakenly private after refactoring them out of
    Player.cs.)
  - PLAYER: Remove unnecessary TODO comment about removing unused
    _isClimbingRight. Just leave it for now, since it should be paired
    with _isClimbingLeft.
@knightofiam knightofiam merged commit 62c1b7b into master Dec 10, 2020
knightofiam added a commit that referenced this pull request Dec 11, 2020
- Attempt #6 at removing 'v' from release version in deploy.yml as it
  doesn't work with butler for publishing to itch.io.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant