Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project configuration #1280

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Remove project configuration #1280

merged 1 commit into from
Jul 1, 2021

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Jul 1, 2021

Because:

  • I noticed that this system did not work as expected: it uses the pwd of the Pluto server to resolve the environment for notebook processes. We want these to be disconnected.
  • Since 🎁 Built-in Pkg management #844, the environment is now either embedded in the notebook file (default), or set up using Pkg.activate inside notebook code.

Finally, this option conflicts with the new Pkg logic, and no longer works. Let's see if the need for such an option arises again, but the new Pkg behaviour might cover all use cases.

@fonsp fonsp merged commit 6fc1ff0 into main Jul 1, 2021
@fonsp fonsp deleted the remove-project-config branch July 1, 2021 23:04
@fonsp
Copy link
Owner Author

fonsp commented Jul 5, 2021

To add to this:

I noticed that this system did not work as expected: it uses the pwd of the Pluto server to resolve the environment for notebook processes. We want these to be disconnected.

I removed this behaviour because it was confusing. For the same reason that launching julia in a project dir does not activate it: "starting julia Pluto in a directory is not a sufficiently strong signal from the user that they trust the content of that directory and want to let it control what code they run" (from Stefan Karpinski JuliaLang/IJulia.jl#820 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant