Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max-width definition from comments #1400

Closed
wants to merge 1 commit into from

Conversation

Sorien
Copy link

@Sorien Sorien commented Apr 6, 2020

it makes problems when you have to override it to fill parent element, you can use max-width: unset but it's not supported in IE/Edge

@Sorien Sorien changed the title Remove max-width definition Remove max-width definition from comments Apr 6, 2020
@lubber-de lubber-de changed the base branch from master to develop April 6, 2020 12:03
@lubber-de
Copy link
Member

Please rebase your branch to develop to reduce the amount of commits. We are not merging PRs into master. Thanks

Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to the develop branch

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-changes Anything which is awaiting changes labels Apr 6, 2020
it makes problems when you have to override it to fill parent element, you can use `max-width: unset` but it's not supported in IE/Edge
@Sorien
Copy link
Author

Sorien commented Apr 6, 2020

@lubber-de done, sorry for this

@Sorien Sorien requested a review from lubber-de April 6, 2020 14:15
@lubber-de lubber-de removed the state/awaiting-changes Anything which is awaiting changes label Apr 6, 2020
@Sorien Sorien closed this Apr 10, 2020
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants