Fix icon not found error while vs-code packaging #350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the following error while doing
![image](https://user-images.githubusercontent.com/4970420/99440491-82a11900-28cb-11eb-9426-5bd778635964.png)
yarn package-extension
under folder foam-vscodeTurns out that vsce will somehow drop a default .vscodeignore, therefore seems the icon folder outside of foam-vscode is undetectable to vsce.
https://stackoverflow.com/questions/44423212/error-detecting-icon-when-publishing-vscode-extension
This error can be fixed by moving the icon folder into the foam-vscode folder.
![image](https://user-images.githubusercontent.com/4970420/99440672-bed47980-28cb-11eb-882c-86dc3098f2a5.png)
Not sure whether this is a good practice though, since this icon might be shared with other non-vscode components in the codebase.