Fix #1298. Wikilink definitions links not working.

[MABruni]

This is a fix for #1298.

The issue was that link creation was being done literally, and some special characters can break URLs, for example:

• Create placeholder note [[test:1]]
• Click on the link to create the note and save.
• Update wikilink definitions: This creates a link that is interpreted as linking to a note called 1 instead of test:1
• The original note changes to a placeholder note because now it links to a note called "1" that doesn't exist.

The solution involves using encodeURIComponent() to properly encode special characters in the generated links. This ensures that links work with several unsafe special characters that were breaking links before (:, ?, ^, {, }, ~, %).

[riccardoferretti]

That looks great, thanks @MABruni! Could you add a test for it?

[MABruni]

Thank you, @riccardoferretti!

I have added two tests, one to check that encoding is handled correctly and the original filename is preserved and another one to check that links generated resolve correctly. Both of them test wikilinks containing the most common symbols that can break a URL. I also had to modify some previous tests to handle the encoded links.

I tried to be consistent with previous tests and I checked that all of them pass; but let me know if there is anything that I may have overlooked!

[riccardoferretti]

Looking good thx!

[riccardoferretti]

@allcontributors add @MABruni for code

[allcontributors]

@riccardoferretti

I've put up a pull request to add @MABruni! 🎉