Add NoteLink.position to keep track of link ranges #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevakallio
commented
Jul 13, 2020
| to: node.value as string, | ||
| text: node.value as string, | ||
| position: node.position! |
There was a problem hiding this comment.
Technically node.position may be null, but this should only be the case when the links have been generated/appended to the tree and not yet committed. The nodes here are always in markdown, and therefore should always have positions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked this off from #107, as it's likely we'll need this for other core/janitor features before the spike can land.
NoteLink.positionfield to attach Markdown AST positional information to links, to be used by VS Code providers.