Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize docs folder; isolate dev docs and user docs; integrate foam-template docs #1031

Merged
merged 8 commits into from
Jul 26, 2022

Conversation

infogulch
Copy link
Contributor

@infogulch infogulch commented Jul 11, 2022

This is a WIP PR to reorganize the docs according to the discussion in #1025.

TODO:

  • Finish writing docs/user/index.md
    • Add recipes list
  • Merge graph-visualisation.md + graph-visualization.md
  • Regenerate all link reference definitions
  • Finish centralizing dev docs
  • Make sure the site still generates correctly
  • Develop and document a repeatable method to transfer user docs into the foam-template repo

@riccardoferretti
Copy link
Collaborator

The organization of the docs in user and dev makes a lot of sense to me 👍

Will monitor updates to leave comments as things progress, if you have any question for me feel free to ping!

@infogulch infogulch marked this pull request as ready for review July 16, 2022 21:49
@infogulch
Copy link
Contributor Author

infogulch commented Jul 16, 2022

I finished the fixups that were apparent to me and everything looks kosher. However, I'm not sure how to validate that the website still generates correctly, and I'm not sure what approach we want to take to automatically syncing over to the foam-template repo.

Thoughts?

Copy link

@DrakeWhu DrakeWhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review and all seems good, I just suggest adding the graph visualization links in two files where they seem to be missing

docs/index.md Show resolved Hide resolved
@infogulch
Copy link
Contributor Author

infogulch commented Jul 17, 2022

Good callouts, I think the missing links were caused by misspelling "visualization" (with an s instead of a z) which prevented the "link reference definition" feature from auto-generating the links. Besides the ones you found I cleaned up a few other cases as well.

@infogulch
Copy link
Contributor Author

On a side note, I tried using the "workspace janitor" tool, to redo all the references, but that just made a mess of all the reference sections that it changed. I ended up opening every file individually and saving it a couple times to get the autofix tool to work correctly.

Copy link

@DrakeWhu DrakeWhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good now

@DrakeWhu
Copy link

I could make sure the site generates correctly. I'm not sure on how to do it but I would be glad to help

Copy link
Collaborator

@riccardoferretti riccardoferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like such a massive improvement of the docs!

@riccardoferretti
Copy link
Collaborator

I am thinking of already merging the PR in this state, and take the last point on a separate PR, wdyt?

(re the site, it should work without problems as we still have the index file)

@infogulch
Copy link
Contributor Author

infogulch commented Jul 21, 2022

Yes it absolutely makes sense to merge this now and split the docs-transfer automation into a separate PR.

@riccardoferretti riccardoferretti merged commit 72694ad into foambubble:master Jul 26, 2022
@riccardoferretti
Copy link
Collaborator

@allcontributors add @infogulch for docs

@allcontributors
Copy link
Contributor

@riccardoferretti

I've put up a pull request to add @infogulch! 🎉

@infogulch infogulch deleted the reorg-docs branch March 20, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants