Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] documentation additions and broken link #1357

Closed
Walshkev opened this issue May 24, 2024 · 7 comments
Closed

[doc] documentation additions and broken link #1357

Walshkev opened this issue May 24, 2024 · 7 comments

Comments

@Walshkev
Copy link
Contributor

I noticed that the readme of this project does not contain the contribution guide or community guidelines. I have found the contribution guide deeper with in the repository. I have also found the original code of conduct https://foambubble.github.io/foam/dev/code-of-conduct and the contribution guide https://foambubble.github.io/foam/dev/contribution-guide.html for foam bubble which can be easily linked within the read me. Also, the link on the discord page for the community guidelines is currently broken.

foam broken link

@riccardoferretti
Copy link
Collaborator

Thanks for reporting this @Walshkev! are you happy to do a PR and fix the issue?

@riccardoferretti
Copy link
Collaborator

the link on the discord page for the community guidelines is currently broken

I am not sure I understand which one this is, can you point me to it?

@Walshkev
Copy link
Contributor Author

Walshkev commented May 29, 2024 via email

@Walshkev
Copy link
Contributor Author

i finished the this issue the pull request is [doc] documentation additions #1358

@riccardoferretti
Copy link
Collaborator

Great, thanks! I have merged it

@Walshkev
Copy link
Contributor Author

i found the broken link on the discord channel https://discord.com/channels/729975036148056075/729976283613626408
image
All of the other links are working properly.

@riccardoferretti
Copy link
Collaborator

Thanks for that, I will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants