Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foam-template bot sync not replicating .vscode directory #1299

Closed
dcarosone opened this issue Oct 25, 2023 · 3 comments · Fixed by #1300
Closed

foam-template bot sync not replicating .vscode directory #1299

dcarosone opened this issue Oct 25, 2023 · 3 comments · Fixed by #1300

Comments

@dcarosone
Copy link
Contributor

Describe the bug

The foam-template repo is out of date for the .vscode directory (noticed because of the recommended extensions.json, but probably also other settings changes, and should be included in the bot sync GHA

Small Reproducible Example

No response

Steps to Reproduce the Bug or Issue

clone the template, compare to source in foam repo docs/.vscode

Expected behavior

up to date template

Screenshots or Videos

No response

Operating System Version

n/a

Visual Studio Code Version

n/a

Additional context

No response

dcarosone pushed a commit to dcarosone/foam that referenced this issue Oct 25, 2023
riccardoferretti pushed a commit that referenced this issue Oct 25, 2023
fixes #1299

Co-authored-by: Daniel Carosone <[email protected]>
@MakaryGo
Copy link

Hi.
Now when using the template it puts the necessary files in .vscode/.vscode, so it doesn't initialize properly, seems related to this fix?

@riccardoferretti
Copy link
Collaborator

You are right.
I am looking at the script, and tried it locally, and it copies the files in the right location - am I missing something?
https://github.com/foambubble/foam/blob/master/.github/workflows/update-docs.yml

I guess I can just work around the issue by using *, but I am trying to understand what's happening

@riccardoferretti
Copy link
Collaborator

@MakaryGo this is now fixed. Thanks for reporting it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants