Lua5.3 cpp fixups #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after this commit it works with g++
after this commit, clang++ will compile eris without errors, and the tests pass. tested with clang-3.5 and clang-3.7 also, put the `typedef int bool;` behind `#ifndef __cplusplus`
|
Thanks a lot! (And sorry for the delay, was on vacation for a few days.) |
|
No problem, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21
It turned out there were more random things I needed to do to get clang to be happy to compile, mainly, clang++ wasn't willing to allow implicit conversions of (void*) to and from other things even when
-fpermissivewas used. When compiling as C I guess it was fine with it.Maybe there was some flag I don't know about, but on the other hand clang++ was fine with the rest of lua.
Another thing I did was put the
typedef int boolbehind a#ifndef __cplusplus, apparently only gcc is actually willing to just ignore that, clang calls it an error.