Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 more constexprs to fix compile error #4065

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

torshepherd
Copy link
Contributor

Example code where this fails:

https://compiler-explorer.com/z/31d3bjxer

With my branch this code succeeds just fine (the compilation error is on purpose, this is cat implemented as a compile error:

https://compiler-explorer.com/z/EzEY6Tse9

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please apply clang-format.

@torshepherd
Copy link
Contributor Author

done

@vitaut vitaut merged commit 3fe4641 into fmtlib:master Jul 13, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants