Sorting #1
Open
Sorting #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
email functionality was removed.
fmorato
reviewed
Dec 2, 2019
| @@ -28,6 +28,7 @@ def __init__(self, params=None, config=None): | |||
|
|
|||
| def start(self): | |||
| self.session = ClientSession( | |||
| connector=TCPConnector(verify_ssl=False), | |||
There was a problem hiding this comment.
We shouldn't make this a default. You can add it as a cli option in a different PR if you want.
fmorato
reviewed
Dec 2, 2019
| @@ -61,3 +61,10 @@ def persist_db(query, data): | |||
| def clear_db(): | |||
| with shelve.open(SAVE_FILE) as db: | |||
| db.clear() | |||
|
|
|||
| def convert_str_to_float(string): | |||
| trimed_string = ''.join(e for e in string if e.isnumeric()) | |||
There was a problem hiding this comment.
This doesn't work for numbers with decimal places, for eg. 23.50.
fmorato
reviewed
Dec 2, 2019
| result[item_id] = new_item | ||
|
|
||
| self.print_result(result,self.config) |
There was a problem hiding this comment.
The printing functionality is in the vahti.py file. You should instead modify the result.
fmorato
requested changes
Dec 2, 2019
225d0b6
to
54e717f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add command line to support sorting of results
-Now, support sort by price and title with arg "-s price(or title)"