Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require deadline for deletion of backups #27

Open
tobisalad opened this issue May 25, 2022 · 3 comments
Open

Don't require deadline for deletion of backups #27

tobisalad opened this issue May 25, 2022 · 3 comments

Comments

@tobisalad
Copy link

The deletion of the oldest backup when reaching the Maximum number of packages-number is only executed when the Remove backup packages older than-deadline is also set, this is not mentioned anywhere and also not desirable. This could easily be fixed by removing || empty($deadline) from line 202 of FTPClient.php and adding an empty($deadline)-check around the second half of line 225.

@flydev-fr
Copy link
Owner

@tobisalad thanks for the comment.

I can remember a discussion from 2017 with @adrianbj about this subject.

I need to check the code and the commits and I will be back to this issue. Can you confirm you are on the very last version ?
Do you spotted if It happen only when using FTP mode ?

Stay tuned.

@tobisalad
Copy link
Author

It says that I'm on version v1.4.21, which I believe is the latest, I also checked in this repository and the code is the same here.
It correctly deletes backups when using local storage (though not the respective log-files, which is a separate issue).

@flydev-fr
Copy link
Owner

Ok thank you. I don't remember right now why I coded this feature to only works when the setting Local Folder in ON.

I will check it and will also fix the log deletion.

flydev-fr added a commit that referenced this issue Oct 2, 2022
If this setting is set to `true`, orphaned log files will be deleted from disk. Use this setting to cleanup old files from your folder.

- also referenced there:
_Originally posted by @tobisalad in #27 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants