fix: close old websocket before every connection attempt #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a websocket fails to connect it doesn't seem to close but stays open (visible in the debugger and in ram usage). If the MCDU Server is not used this leaks a Websocket connection every attempt.
Benjozork
approved these changes
Mar 18, 2022
|
Merging this as it's been approved and a trivial fix that doesn't change the behaviour and functionality of the feature. |
Saschl
added a commit
to Saschl/a32nx
that referenced
this pull request
Mar 20, 2022
…bywiresim#6937)" This reverts commit 774dbcb.
Benjozork
pushed a commit
that referenced
this pull request
Mar 20, 2022
ErickSharp
pushed a commit
that referenced
this pull request
Apr 3, 2022
If a websocket fails to connect it doesn't seem to close but stays open (visible in the debugger and in ram usage). If the MCDU Server is not used this leaks a Websocket connection every attempt.
ErickSharp
pushed a commit
that referenced
this pull request
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
If a Websocket fails to connect it doesn't seem to close but stays open (visible in the debugger and in ram usage). If the MCDU Server is not used this leaks a Websocket connection every attempt. This slowly fills up the RAM and lead to increased CPU usage.
I removed the "readyState" condition on a reconnect so the old socket is closed and properly garbage collected.
Screenshots (if necessary)
Before:
Lots of sockets...
After:
Just one WebSocket that also reports closed.
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.