-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pfd): add EIS standard S14 features #6919
feat(pfd): add EIS standard S14 features #6919
Conversation
a02270c
to
22c679a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Quality Assurance Tester Report Discord : mico#3145 Testing Process: Negatives: Testing Results: Conclusions: |
Quality Assurance Report Discord: !davidn123#0001 Testing Process: Tested on a full flight & tested the following: Active autobrake modes in the 1st line of the 1st column. These show the active A/BRK mode, if no A/THR mode is shown.-PASSED Negatives: N/A Testing Results: Passed Conclusions: n/a |
* feat(pfd): add A/BRK mode indications on FMA * feat(pfd): show selected alt indicator in white in certain vertical modes * fix(pfd): correct BRK LO alignment * fix(pfd): block correct target speed offtape text when DECEL active * feat(A/BRK): Add A/BRK active simvar and switch PFD to it Co-authored-by: Benedict Etzel <[email protected]>
Fixes #[issue_no]
Summary of Changes
This PR adds EIS standard S14 features to the PFD. These include:
The final change of S14 are the numbers next to the linear deviation indicator. These only make sense with VNAV, and are implemented already on experimental with the reworked PFD, so I've chosen not to add them in this PR.
Note that the BRK MAX indication on the third line is actually an addition of S15, on S14 this would be also on the second line.
I've chosen to already implement it like in S15.
Finally, the condition for classifying A/BRK as "active" is currently just DECEL being active. This is not correct, it should be a seperate signal, for example it is possible to have A/BRK not reach the target deceleration on a slippery runway, in which case the A/BRK mode should show in green, while DECEL is not shown. This is the reason this PR is still in draft, I'm awaiting this signal to be implemented.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.