Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pfd): add EIS standard S14 features #6919

Merged
merged 9 commits into from
Mar 18, 2022

Conversation

lukecologne
Copy link
Member

@lukecologne lukecologne commented Mar 15, 2022

Fixes #[issue_no]

Summary of Changes

This PR adds EIS standard S14 features to the PFD. These include:

  • Autobrake indications on the PFD
    • Active autobrake modes in the 1st line of the 1st column. These show the active A/BRK mode, if no A/THR mode is shown.
    • Armed autobrake modes, except BRK MAX in the 2nd line of the 1st column. These show the armed A/BRK mode, if no 2-line A/THR mode is active (i.e. MAN TOGA, MAN FLX etc.)
    • BRK MAX in the 3rd line of the 1st column. This is shown if the A/BRK MAX mode is armed, and if no other message (for example SPD SEL, MACH SEL, THR CLB etc.) is shown in this area.
    • DECEL indication below the speed tape. This has the same conditions as the DECEL light on the A/BRK buttons, and hides the lower selected speed text if it would be shown there.
  • White selected altitude indicator, if a vertical AP/FD mode is active that ignores the selected altitude (i.e. G/S, G/S*, ROLL OUT, FLARE, LAND, FINAL APP)

The final change of S14 are the numbers next to the linear deviation indicator. These only make sense with VNAV, and are implemented already on experimental with the reworked PFD, so I've chosen not to add them in this PR.
Note that the BRK MAX indication on the third line is actually an addition of S15, on S14 this would be also on the second line.
I've chosen to already implement it like in S15.

Finally, the condition for classifying A/BRK as "active" is currently just DECEL being active. This is not correct, it should be a seperate signal, for example it is possible to have A/BRK not reach the target deceleration on a slippery runway, in which case the A/BRK mode should show in green, while DECEL is not shown. This is the reason this PR is still in draft, I'm awaiting this signal to be implemented.

Screenshots (if necessary)

grafik
grafik
grafik

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@lukecologne lukecologne marked this pull request as draft March 15, 2022 02:04
@lukecologne lukecologne marked this pull request as ready for review March 15, 2022 20:26
Copy link
Member

@tracernz tracernz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@mico975
Copy link
Contributor

mico975 commented Mar 16, 2022

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #6919
Tier of Testing : 1
Date : 16/03/2022

Testing Process:
Autobrake indications on the PFD
Active autobrake modes in the 1st line of the 1st column. These show the active A/BRK mode, if no A/THR mode is shown. - OK
Armed autobrake modes, except BRK MAX in the 2nd line of the 1st column. These show the armed A/BRK mode, if no 2-line A/THR mode is active (i.e. MAN TOGA, MAN FLX etc.) - OK
BRK MAX in the 3rd line of the 1st column. This is shown if the A/BRK MAX mode is armed, and if no other message (for example SPD SEL, MACH SEL, THR CLB etc.) is shown in this area. - OK
DECEL indication below the speed tape. This has the same conditions as the DECEL light on the A/BRK buttons, and hides the lower selected speed text if it would be shown there. - OK
White selected altitude indicator, if a vertical AP/FD mode is active that ignores the selected altitude (i.e. G/S, G/S*, ROLL OUT, FLARE, LAND, FINAL APP) - OK

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

Media:
image
image

@davidnorfolk96
Copy link

Quality Assurance Report

Discord: !davidn123#0001
Object of testing: 6919
Tier of Testing: 1
Date: 18/03/2022

Testing Process: Tested on a full flight & tested the following:

Active autobrake modes in the 1st line of the 1st column. These show the active A/BRK mode, if no A/THR mode is shown.-PASSED
Armed autobrake modes, except BRK MAX in the 2nd line of the 1st column. These show the armed A/BRK mode, if no 2-line A/THR mode is active (i.e. MAN TOGA, MAN FLX etc.)-PASSED
BRK MAX in the 3rd line of the 1st column. This is shown if the A/BRK MAX mode is armed, and if no other message (for example SPD SEL, MACH SEL, THR CLB etc.) is shown in this area.-PASSED
DECEL indication below the speed tape. This has the same conditions as the DECEL light on the A/BRK buttons, and hides the lower selected speed text if it would be shown there.-PASSED
White selected altitude indicator, if a vertical AP/FD mode is active that ignores the selected altitude (i.e. G/S, G/S*, ROLL OUT, FLARE, LAND, FINAL APP)-PASSED

Negatives: N/A

Testing Results: Passed

Conclusions: n/a

Media:
Screenshot_5
Screenshot_6

@lukecologne lukecologne merged commit 278afe7 into flybywiresim:master Mar 18, 2022
@lukecologne lukecologne deleted the pfd-s14-features branch March 18, 2022 19:41
ErickSharp pushed a commit that referenced this pull request Apr 3, 2022
* feat(pfd): add A/BRK mode indications on FMA

* feat(pfd): show selected alt indicator in white in certain vertical modes

* fix(pfd): correct BRK LO alignment

* fix(pfd): block correct target speed offtape text when DECEL active

* feat(A/BRK): Add A/BRK active simvar and switch PFD to it

Co-authored-by: Benedict Etzel <[email protected]>
@2hwk 2hwk added this to the v0.8.0 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants