Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hyd): ptu starting sound #6885

Merged
merged 4 commits into from
Mar 13, 2022

Conversation

crocket63
Copy link
Contributor

Fixes #[issue_no]

Summary of Changes

New PTU dynamics made the starting sound less likely to trigger.

Now PTU starting sound should trigger easily on each first ptu run

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

Check that anytime ptu is activated (by whatever mean, be creative), if there's more than 2800 psi difference from green to yellow system (in whatever direction), high pitch ptu sound should be heard.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@davidwalschots davidwalschots changed the title fix(hyd): Ptu starting sound fix(hyd): ptu starting sound Mar 11, 2022
@mico975
Copy link
Contributor

mico975 commented Mar 12, 2022

Quality Assurance Tester Report

Discord : mico#3145
Object of testing: #6885
Tier of Testing : 1
Date : 12/03/2022

Testing Process:
Check that anytime ptu is activated (by whatever mean, be creative), if there's more than 2800 psi difference from green to yellow system (in whatever direction), high pitch ptu sound should be heard. - OK

Negatives:
N/A

Testing Results:
Passed

Conclusions:
LGTM

@davidwalschots davidwalschots merged commit 74995b7 into flybywiresim:master Mar 13, 2022
frankkopp pushed a commit to frankkopp/aircraft that referenced this pull request Mar 13, 2022
ErickSharp pushed a commit that referenced this pull request Apr 3, 2022
@2hwk 2hwk added this to the v0.8.0 milestone Apr 29, 2022
@crocket63 crocket63 deleted the fix_ptu_high_sound branch August 18, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants