-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adirs): Improve ADIRS SSM and behaviours #6636
Conversation
7951aa8
to
029e504
Compare
32eeffd
to
c12f0b7
Compare
c12f0b7
to
ddc75b3
Compare
ddc75b3
to
832c6df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor remark on a test. In general I don't do this, but this time I've created a PR here, which you could merge in if you deem it useful: lukecologne#1
a0b45b4
to
f71bf65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the Rust side of things. Looks good!
fa37b58
to
a53d518
Compare
44c86a5
to
f9bd67a
Compare
Quality Assurance Trainee Report Object of testing: #6636 Testing Process: Make sure that the bird and the FPV flag on the PFD in TRK/FPA mode beave as described above and are plausible - no issues noted in normal operations Make sure that the CAS/TAS/mach values (and invalidity flags) on the ND/PFD behave as described above and are plausible - checked Unfortunately, the other parameters added (AoA, the rotation rates and accelerations) cannot be easily checked without decoding the Arinc429 values and looking at the numeric value, so they probably cannot be tested properly. - not checked Had a couple game crashes just need to verify they are not PR related - tomorrow Negatives: Note: This isn't the most thorough test but it is what I could do at the moment. More than this test should be done. |
Quality Assurance Tester Report Discord : mico#3145 Testing Process: Negatives: Testing Results: Conclusions: |
17b34c2
to
494cd06
Compare
494cd06
to
031988c
Compare
* fix(adr): every ADR now outputs temperature data * fix(adr): correct tests for previous commit * fix(adr): Correct behavior of labels when ADR off or low speed * fix(pfd): adjust PFD indications for changed ADR SSMs * adjust conditions for mach flag display to match video reference * add remaining unit tests for mach and CAS conditions * fix(pfd): use actual airspeed value instead of arinc word * feat(adr): add AoA to ADR outputs * feat(IR): add drift angle calculation * refactor: clarifying functions * remove extraneous and() from drift angle unit test * feat(adirs): add more IR data labels * chore: update ADIRS Lvar documentation * chore(adirs): add unit tests for new IR data * feat(pfd): move to dedicated FPA/DA IRS vars, add FPV flag * chore: add changelog entries * fix: lint errors Co-authored-by: David Walschots <[email protected]>
Summary of Changes
This PR:
The FPA and DA are now used for the FPV on the PFD. In case of FPA or DA set as FW/NCD, the FPV flag is now shown (when the attitude is still valid and TRK/FPA mode is active, for example when the IR is in ATT mode).
Also, if the CAS goes below 30kts in flight, the SPD flag is shown now, since CAS is then coded NCD.
Finally, if mach is not valid, the MACH flag is not shown on ground, only in flight. This means that if MACH goes below 0.1 in the air, the MACH flight will also be shown, since it is coded NCD in that case.
Screenshots (if necessary)
https://streamable.com/hudxhn
References
For low airspeeds and extreme attitudes, I found these videos, in which you can clearly see the SPD and MACH flag, and also the FPV snapping away below 50kts:
https://www.youtube.com/watch?v=Eap-3siSgLc
https://www.youtube.com/watch?v=rKEKwYTvuZU
https://www.youtube.com/watch?v=AYm1aLu49Pk
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.