Skip to content

Commit

Permalink
[chore] Add status metadata to signalfx exporter (open-telemetry#21258)
Browse files Browse the repository at this point in the history
  • Loading branch information
atoulme authored May 1, 2023
1 parent 11096ef commit c97f839
Show file tree
Hide file tree
Showing 6 changed files with 39 additions and 19 deletions.
18 changes: 10 additions & 8 deletions exporter/signalfxexporter/README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
# SignalFx Metrics Exporter

| Status | |
| ------------------------ |-------------------------------------------------------------------|
| Stability | [beta] |
| Supported pipeline types | logs (events), metrics, traces (trace to metric correlation only) |
| Distributions | [contrib] |
<!-- status autogenerated section -->
| Status | |
| ------------------------ |-----------|
| Stability | [beta] |
| Supported pipeline types | logs, metrics, traces |
| Distributions | [contrib] |

[beta]: https://github.com/open-telemetry/opentelemetry-collector#beta
[contrib]: https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib
<!-- end autogenerated section -->

This exporter can be used to send metrics, events, and trace correlation to SignalFx.

Expand Down Expand Up @@ -290,6 +295,3 @@ Several helper files are leveraged to provide additional capabilities automatica
- [HTTP settings](https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/confighttp/README.md)
- [TLS and mTLS settings](https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configtls/README.md)
- [Queuing, retry and timeout settings](https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/README.md)
[beta]:https://github.com/open-telemetry/opentelemetry-collector#beta
[contrib]:https://github.com/open-telemetry/opentelemetry-collector-releases/tree/main/distributions/otelcol-contrib
5 changes: 3 additions & 2 deletions exporter/signalfxexporter/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"go.uber.org/zap"

"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter/internal/correlation"
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter/internal/metadata"
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter/internal/translation"
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter/internal/translation/dpfilters"
"github.com/open-telemetry/opentelemetry-collector-contrib/internal/splunk"
Expand All @@ -58,11 +59,11 @@ func TestLoadConfig(t *testing.T) {
expected *Config
}{
{
id: component.NewIDWithName(typeStr, ""),
id: component.NewIDWithName(metadata.Type, ""),
expected: defaultCfg,
},
{
id: component.NewIDWithName(typeStr, "allsettings"),
id: component.NewIDWithName(metadata.Type, "allsettings"),
expected: &Config{
AccessToken: "testToken",
Realm: "us1",
Expand Down
2 changes: 2 additions & 0 deletions exporter/signalfxexporter/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:generate mdatagen metadata.yaml

// Package signalfxexporter implements an exporter that sends data to SignalFx.
package signalfxexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter"
14 changes: 5 additions & 9 deletions exporter/signalfxexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,12 @@ import (
"go.uber.org/zap"

"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter/internal/correlation"
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter/internal/metadata"
"github.com/open-telemetry/opentelemetry-collector-contrib/internal/splunk"
"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/batchperresourceattr"
)

const (
// The value of "type" key in configuration.
typeStr = "signalfx"
// The stability level of the exporter.
stability = component.StabilityLevelBeta

defaultHTTPTimeout = time.Second * 5

defaultMaxConns = 100
Expand All @@ -45,11 +41,11 @@ const (
// NewFactory creates a factory for SignalFx exporter.
func NewFactory() exporter.Factory {
return exporter.NewFactory(
typeStr,
metadata.Type,
createDefaultConfig,
exporter.WithMetrics(createMetricsExporter, stability),
exporter.WithLogs(createLogsExporter, stability),
exporter.WithTraces(createTracesExporter, stability),
exporter.WithMetrics(createMetricsExporter, metadata.Stability),
exporter.WithLogs(createLogsExporter, metadata.Stability),
exporter.WithTraces(createTracesExporter, metadata.Stability),
)
}

Expand Down
12 changes: 12 additions & 0 deletions exporter/signalfxexporter/internal/metadata/generated_status.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions exporter/signalfxexporter/metadata.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
type: signalfx

status:
class: exporter
stability: beta
pipelines: [logs, metrics, traces]
distributions: [contrib]

0 comments on commit c97f839

Please sign in to comment.