App mesh additional listener settings #945
Open
+620
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add setting in Canary.Service for AWS App Mesh outlier detection. Handle outlier detection settings in VirtualNode reconcile for appmeshv1beta2 router. Permits customization of canary and primary VirtualNodes. Resolves: fluxcd#797 Signed-off-by: Kevin Phillips <[email protected]>
Adds connection pool settings for generated VirtualNode listerner. Handle pool configuration in virtual node reconcile logic in appmesh v1beta2 router. Permits further customization of virtual node generated by flagger. Resolves: fluxcd#797 Signed-off-by: Kevin Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, these changes will allow for further customization of listener settings for generate virtual nodes -- outlier detection and connection pooling. Left separate from istio
trafficPolicyto avoid confusion around capabilities.Resolves: #797
Signed-off-by: Kevin Phillips [email protected]