Traefik support #736
Merged
Traefik support #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
reviewed
Dec 1, 2020
stefanprodan
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #499
Traefik has a TraefikService crd resource, which enables us to do weighted load balancing between multiple kubernetes services.
The only nuance that I've stumbled upon is that
traefikstops to recognizeTraefikServiceif one of the services in it have 0 endpoints, which is the case for promoted canary. So I have to remove canary service fromTraefikServicewhen canary weight is set to 0.What has been done:
traefikimplementation and tests for router interfacetraefikimplementation and tests for observer interface. "request-success-rate" and "request-duration" queries are implemented via prometheus metrics provider, by querying metrics exposed bytraefikProof
Traffic distribution when canary is successful
Traffic distribution when canary failed