Fix removal of empty keys from flagger chart #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamnarula
force-pushed
the
fix/empty-annotations-and-volumes
branch
2 times, most recently
from
0629268
to
08fbe82
Compare
stefanprodan
approved these changes
Jun 12, 2024
Signed-off-by: Shivam Narula <[email protected]>
aryan9600
force-pushed
the
fix/empty-annotations-and-volumes
branch
from
08fbe82
to
3490d60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1657 +/- ##
==========================================
+ Coverage 34.10% 34.44% +0.34%
==========================================
Files 282 283 +1
Lines 20556 20691 +135
==========================================
+ Hits 7010 7128 +118
- Misses 12616 12627 +11
- Partials 930 936 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If annotations is empty for serviceAccounts
annotationsshows as empty key while generating the helm chart. Same goes withvolumesandvolumeMountsin deployment.This PR fix the above issue.