Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AssetEntityImageProvider asset thumbSize length error , when previewThumbSize is null #60

Closed
wants to merge 1 commit into from
Closed

fix AssetEntityImageProvider asset thumbSize length error , when previewThumbSize is null #60

wants to merge 1 commit into from

Conversation

JasonHezz
Copy link
Contributor

No description provided.

@AlexV525
Copy link
Member

In which cases this can be null?

@JasonHezz
Copy link
Contributor Author

click image and navigate to preview page
image

image

@AlexV525 AlexV525 added await investigate The issue is waiting for further investigation. s: bug Something isn't working. b: severe This issue need to be fixed ASAP. and removed await investigate The issue is waiting for further investigation. labels Aug 19, 2020
@AlexV525
Copy link
Member

Confirmed, but I'll fix this in another way. I'll notify you once it's done. Thanks for this fix!

@AlexV525 AlexV525 closed this Aug 19, 2020
AlexV525 added a commit that referenced this pull request Aug 19, 2020
@AlexV525
🐛 Fix arguments judging condition with preview thumb size.
87e913b 
Resolves #60 .
@AlexV525
Copy link
Member

Can you try with the commit I've linked to see if it's fixed?

@AlexV525 AlexV525 added await response Issue require customer's further response. release candidate ⏳TODAY This issue is scheduled to be solved today. labels Aug 19, 2020
@JasonHezz
Copy link
Contributor Author

Can you try with the commit I've linked to see if it's fixed?

Yep, work as expected, can you release a new version?

@AlexV525 AlexV525 removed the await response Issue require customer's further response. label Aug 19, 2020
@AlexV525
Copy link
Member

Yep, work as expected, can you release a new version?

On it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
b: severe This issue need to be fixed ASAP. s: bug Something isn't working. ⏳TODAY This issue is scheduled to be solved today.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JasonHezz @AlexV525