Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Improve audio item layout #221

Merged
merged 5 commits into from Nov 23, 2021
Merged

🎨 Improve audio item layout #221

merged 5 commits into from Nov 23, 2021

Conversation

yanivshaked
Copy link
Contributor

With current display, file name is cut, most of the real estate is used by the audio track symbol:

Suggesting to use 3 lines for the filename, moving the audio track next to the duration:

AlexV525
AlexV525 approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the icon seems not aligned pretty, can it be improved?

@yanivshaked
Copy link
Contributor Author

Fixed:

@AlexV525
Copy link
Member

Also, a2dd6fc seems to be an invalid cherry-pick.

@yanivshaked
Copy link
Contributor Author

Also, a2dd6fc seems to be an invalid cherry-pick.

Fixed

AlexV525
AlexV525 approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanivshaked yanivshaked merged commit 3bccdf9 into fluttercandies:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yanivshaked @AlexV525