[Feature] Ability to open asset picker from the same position it was previously closed after confirming assets #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexV525
reviewed
Jul 9, 2021
| @@ -247,6 +247,45 @@ class PickMethod { | |||
| }, | |||
| ); | |||
| } | |||
| static AssetPickerBuilderDelegate<AssetEntity, AssetPathEntity>? _delegate; | |||
There was a problem hiding this comment.
Keep them in the page, don't implement them as static.
| @@ -559,6 +567,12 @@ abstract class AssetPickerBuilderDelegate<Asset, Path> { | |||
| /// Yes, the build method. | |||
| /// 没错，是它是它就是它，我们亲爱的 build 方法~ | |||
| Widget build(BuildContext context) { | |||
| if (_savedScrollPosition != null) { | |||
There was a problem hiding this comment.
Maybe we should use ScrollController(initialScrollOffset: yourSavedScrollPosition) instead.
| @@ -92,6 +92,14 @@ abstract class AssetPickerBuilderDelegate<Asset, Path> { | |||
| /// The [ScrollController] for the preview grid. | |||
| final ScrollController gridScrollController = ScrollController(); | |||
|
|
|||
| /// [ScrollPosition] for resuming ScrollController position. | |||
| /// <zhongwen here> | |||
| ScrollPosition? _savedScrollPosition; | |||
There was a problem hiding this comment.
Is there any difference if you pass a saved ScrollController?
|
Closing in favor of #172 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
pickAssetsWithDelegateSave position