Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Hebrew Support (希伯来文字实现) #103

Merged
merged 5 commits into from Apr 29, 2021
Merged

✨ Hebrew Support (希伯来文字实现) #103

merged 5 commits into from Apr 29, 2021

Conversation

yanivshaked
Copy link
Contributor

Ni hao,

I have added xi bu lai (Hebrew) support.

Fei chang gan xie!,
Yaniv

Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a nit picking.

lib/src/delegates/assets_picker_text_delegate.dart Outdated Show resolved Hide resolved
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing left :)

lib/src/delegates/assets_picker_text_delegate.dart Outdated Show resolved Hide resolved
@AlexV525
Copy link
Member

Seems good to go, merging.

@AlexV525 AlexV525 merged commit 02c925b into fluttercandies:master Apr 29, 2021
@yanivshaked yanivshaked deleted the 20210428_HebrewSupport branch May 7, 2021 18:18
@AlexV525 AlexV525 added the e: localizations Improvements to localizations. label Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e: localizations Improvements to localizations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants