Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fix Wechat Moment preview issue #111

Merged
merged 2 commits into from
May 1, 2021
Merged

馃悰 Fix Wechat Moment preview issue #111

merged 2 commits into from
May 1, 2021

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented May 1, 2021

Resolves #110 .

cc @yanivshaked

@AlexV525 AlexV525 added s: bug Something isn't working. 鈴砊ODAY This issue is scheduled to be solved today. labels May 1, 2021
yanivshaked
yanivshaked approved these changes May 1, 2021
View reviewed changes
Copy link
Contributor

@yanivshaked yanivshaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it should have been in multi assets page.

@AlexV525 AlexV525 merged commit 78f197b into master May 1, 2021
@AlexV525 AlexV525 deleted the fix-wechat-moment-preview branch May 1, 2021 07:54
@yanivshaked
Copy link
Contributor

yanivshaked commented May 1, 2021 •
edited
Loading

While testing, I found the following scenario:

  • Open example with WeChatMoment picker type
  • Click a video to preview it
  • Click the select button at the bottom
  • Click back to go back to the grid
  • Click an image selector to have it selected
  • Now you have two assets selected - one is a video the 2nd is an image (The app bar says 2/9)

(Sorry for the premature approve of changes)

@AlexV525
Copy link
Member Author

AlexV525 commented May 1, 2021

Sounds like we need to disabled the bottom select button when previewing the video in the WeChat Moment picker type.

@yanivshaked
Copy link
Contributor

Correct, that will solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivshaked yanivshaked yanivshaked approved these changes

Assignees
No one assigned
Labels
s: bug Something isn't working. 鈴砊ODAY This issue is scheduled to be solved today.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Ability to choose both video and image in SpecialPickerType.wechatMoment
2 participants
@AlexV525 @yanivshaked