Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ability to choose both video and image in SpecialPickerType.wechatMoment #110

Closed
yanivshaked opened this issue Apr 30, 2021 · 5 comments · Fixed by #111
Closed

[BUG] Ability to choose both video and image in SpecialPickerType.wechatMoment #110

yanivshaked opened this issue Apr 30, 2021 · 5 comments · Fixed by #111
Labels
s: bug Something isn't working. ⏳TODAY This issue is scheduled to be solved today.

Comments

@yanivshaked
Copy link
Contributor

Bug description
When using SpecialPickerType.wechatMoment, I am able to select both image and video files.
I made sure that this bug is NOT related to the noPreview changes.

How to reproduce

  • Run the example
  • Click Single Asset picker page
  • Click WeChat moment
  • Click on an image to get its preview
  • Select it using the "Select" button at the bottom bar
  • Swipe right till you get a video asset
  • Select it using the "Select" button at the bottom bar
  • Click done

Expected behavior
Should not allow selection of video if image is already selected (and vice versa).

Screenshots (If contains)
If needed, I can upload a video.

Device information

  • Device: Android OnePlus 8T
  • OS: Android 10
  • Package Version: 5.1.3 or 5.2.0 (reproduced on both)
  • Flutter Version: 2.0.5

Additional context
Let me know what are your thoughts on solving this, I can submit a PR.

@yanivshaked yanivshaked added the await investigate The issue is waiting for further investigation. label Apr 30, 2021
@github-actions github-actions bot added the await triage The issue is waiting for triage. label Apr 30, 2021
@AlexV525 AlexV525 added s: bug Something isn't working. ⏳TODAY This issue is scheduled to be solved today. and removed await investigate The issue is waiting for further investigation. await triage The issue is waiting for triage. labels May 1, 2021
@AlexV525
Copy link
Member

AlexV525 commented May 1, 2021

We should filtered selected assets with only images in WeChat Moment mode when pushToViewer is called.

@AlexV525
Copy link
Member

AlexV525 commented May 1, 2021

And make the previewing video the only one in the preview list.

@AlexV525
Copy link
Member

AlexV525 commented May 1, 2021

Nvm, I'll apply a quick fix to this.

@AlexV525 AlexV525 added the s: developing This issue in under development. label May 1, 2021
@AlexV525 AlexV525 removed the s: developing This issue in under development. label May 1, 2021
@AlexV525
Copy link
Member

AlexV525 commented May 1, 2021

@all-contributors Add @yanivshaked for bug.

@allcontributors
Copy link
Contributor

@AlexV525

I've put up a pull request to add @yanivshaked! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: bug Something isn't working. ⏳TODAY This issue is scheduled to be solved today.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants