Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to API docs from keywords in tutorial #110

Closed
wants to merge 3 commits into from
Closed

Link to API docs from keywords in tutorial #110

wants to merge 3 commits into from

Conversation

appsforartists
Copy link
Contributor

It's easier to see the diff in rich mode.

I basically went through the tutorial, found all the keywords (by looking for words wrapped in `s), and linked them to the relevant pages from https://domokit.github.io/docs/sky/material/material-library.html

There could probably be a more maintainable way to do this, but for now, it's an improvement.

@abarth what do you think?

appsforartists
appsforartists reviewed Dec 9, 2015
View reviewed changes
tutorial.md
[`final`](https://www.dartlang.org/docs/dart-up-and-running/ch02.html#final-and-const)
member variables. When a component is asked to
[`build`](https://domokit.github.io/docs/sky/material/StatelessComponent/build.html),
it uses these stored values to derive new arguments for the widgets it creates.

In order to build more complex experiences, however - for example, to react
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krisgiesing - can we drop the "however" here? ", however - for example -" is awkward to read.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@abarth
Copy link
Contributor

abarth commented Dec 9, 2015

LGTM, but we should probably link to the docs at https://docs.domokit.org/flutter/ which are more up to date. Thanks!

@appsforartists
Copy link
Contributor Author

@abarth done.

@appsforartists
Copy link
Contributor Author

@abarth The old github.io link was https. The domokit.org link is http.

  1. Should domokit.org support https?
  2. Why is there still a domokit.org when we have flutter.io?

@abarth
Copy link
Contributor

abarth commented Dec 9, 2015

Should domokit.org support https?

The docs are hosted by Google Cloud Storage, which doesn't yet support HTTPS. We might want to add an HTTPS frontend using AppEngine at some point.

Why is there still a domokit.org when we have flutter.io?

We're in the process of getting docs.flutter.io set up. We're just waiting on some folks inside Google to push some buttons to approve the creation of the subdomain.

@abarth
Copy link
Contributor

abarth commented Dec 9, 2015

LGTM

@abarth
Copy link
Contributor

abarth commented Dec 9, 2015

Landed in 594f141

Thanks!

@abarth abarth closed this Dec 9, 2015
@appsforartists
Copy link
Contributor Author

👍

Thanks.

@sethladd
Copy link
Contributor

sethladd commented Dec 9, 2015

Very cool, thanks!

@appsforartists appsforartists deleted the links-in-tutorial branch December 9, 2015 16:59
parlough added a commit to parlough/website that referenced this pull request Jan 20, 2023
@parlough
Fix and cleanup snippets from recent i18n changes (flutter#110)
397ac7a 
* Remove intl_example test and analysis skip

* Fixes and cleanup to snippets from recent i18n changes

* Adjust text around pinning
@khanhnwin khanhnwin mentioned this pull request Jan 25, 2023
Closed
parlough added a commit that referenced this pull request Jan 25, 2023
@parlough
Fix and cleanup snippets from recent i18n changes (#110)
a185295 
* Remove intl_example test and analysis skip

* Fixes and cleanup to snippets from recent i18n changes

* Adjust text around pinning
khanhnwin added a commit that referenced this pull request Jan 26, 2023
@parlough @johnpryan
@khanhnwin @dependabot @loic-sharma @loic-sharma-google @MitchellGoodwin @atsansone @sfshaza2 @ditman @gaaclarke @itsjustkevin
Integrate changes for Flutter Forward and Flutter 3.7 (#8155)
8664546 
* Update build action for website-private repo (#81)

Co-authored-by: Khanh Nguyen <[email protected]>

* Bring PR template up to date & update build for website-private (#96)

* Bring PR template up to date for freeze

* update build to run ci on website-private

* Bump examples/codelabs from `644dc33` to `33aadee` (#95)

Bumps [examples/codelabs](https://github.com/flutter/codelabs) from `644dc33` to `33aadee`.
- [Release notes](https://github.com/flutter/codelabs/releases)
- [Commits](flutter/codelabs@644dc33...33aadee)

---
updated-dependencies:
- dependency-name: examples/codelabs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Khanh Nguyen <[email protected]>

* Bump site-shared from `faddba8` to `04233ee` (#97)

Bumps [site-shared](https://github.com/dart-lang/site-shared) from `faddba8` to `04233ee`.
- [Release notes](https://github.com/dart-lang/site-shared/releases)
- [Commits](dart-lang/site-shared@faddba8...04233ee)

---
updated-dependencies:
- dependency-name: site-shared
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [Windows] Document the dark title bar migration (#98)

* Document Windows dark title bar migration guide

* Update example link

Co-authored-by: Loic Sharma <[email protected]>

* Bump examples/codelabs from `33aadee` to `48a4d2d` (#100)

Bumps [examples/codelabs](https://github.com/flutter/codelabs) from `33aadee` to `48a4d2d`.
- [Release notes](https://github.com/flutter/codelabs/releases)
- [Commits](flutter/codelabs@33aadee...48a4d2d)

---
updated-dependencies:
- dependency-name: examples/codelabs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Migrate check_link_references tool to be Dart based (#99)

* Migrate check_link_references tool to be Dart based
Also enable the workflow for flutter-forward-23 so broken links are found.

* Add a success confirmation message

* Adjust name of workflow for new behavior

* Simplify workflow name

* Clean up messaging and names

* Update linkcheck to null-safe release (#101)

* Update to Ruby 3.2 with fix to liquid (#102)

* Bump examples/codelabs from `48a4d2d` to `907b2a4` (#105)

* Add CupertinoList widgets to the catalog (#107)

* Bump github/codeql-action from 2.1.37 to 2.1.38 (#111)

* Bump examples/codelabs from `907b2a4` to `caeae28` (#112)

Bumps [examples/codelabs](https://github.com/flutter/codelabs) from `907b2a4` to `caeae28`.
- [Release notes](https://github.com/flutter/codelabs/releases)
- [Commits](flutter/codelabs@907b2a4...caeae28)

---
updated-dependencies:
- dependency-name: examples/codelabs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix and cleanup snippets from recent i18n changes (#110)

* Remove intl_example test and analysis skip

* Fixes and cleanup to snippets from recent i18n changes

* Adjust text around pinning

* Add linguist override to increase language accuracy (#115)

* Add new commands to Flutter CLI reference (#116)

* Add localization entries to Flutter pubspec reference (#114)

Fixes #7456

* Update 'intl_example' to use 'intl_translation' and add basic test (#113)

* Update 'intl_example' to use 'intl_translation' and add basic test

* Add new line at end of file

* Remove lastModified

* Refresh code excerpts

Co-authored-by: Anthony Sansone <[email protected]>

* Update 'Obfuscating Dart code' for updated platform support (#108)

* Update 'Obfuscating Dart code' for updated platform support

* Add Linux to list of supported build targets as well

* Switch to info for the web note

* Use code font for the supported build targets

* Make web note more concise

Co-authored-by: Anthony Sansone <[email protected]>

* Make adjustments to pre-existing writing from feedback

* Switch list format

* Switch app back to code

Co-authored-by: Anthony Sansone <[email protected]>

* Update base Docker image to bullseye from buster (#103)

* Update base Docker image to bullseye from buster

* Use slim version of bullseye

Co-authored-by: Anthony Sansone <[email protected]>

* Bump examples/codelabs from `caeae28` to `57bed10` (#117)

* Bump pigeon in /examples/development/platform_integration (#118)

Bumps [pigeon](https://github.com/flutter/packages/tree/main/packages) from 5.0.1 to 6.0.1.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/pigeon-v6.0.1/packages)

---
updated-dependencies:
- dependency-name: pigeon
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Khanh Nguyen <[email protected]>

* fix examples for beta (#119)

* fix examples for beta

* update build.yml for beta build

* Adding a page on false positives from security tools (#120)

* Adding a page on false positives from security tools

* Incorporating feedback

* Updating the security page (#124)

* Adding a page on false positives from security tools

* Updating the security page and adding a link to the new false security errors page.

* Bump examples/codelabs from `57bed10` to `fa74033` (#121)

Bumps [examples/codelabs](https://github.com/flutter/codelabs) from `57bed10` to `fa74033`.
- [Release notes](https://github.com/flutter/codelabs/releases)
- [Commits](flutter/codelabs@57bed10...fa74033)

---
updated-dependencies:
- dependency-name: examples/codelabs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump googleapis from 9.2.0 to 10.0.0 in /examples/googleapis (#123)

Bumps [googleapis](https://github.com/google/googleapis.dart/tree/master/generated) from 9.2.0 to 10.0.0.
- [Release notes](https://github.com/google/googleapis.dart/releases)
- [Commits](https://github.com/google/googleapis.dart/commits/googleapis-v10.0.0/generated)

---
updated-dependencies:
- dependency-name: googleapis
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github/codeql-action from 2.1.38 to 2.1.39 (#127)

* Update activesupport and nokogiri (#126)

* Remove duplicated false positives page (#125)

* Bump examples/codelabs from `fa74033` to `2adc98c` (#128)

Bumps [examples/codelabs](https://github.com/flutter/codelabs) from `fa74033` to `2adc98c`.
- [Release notes](https://github.com/flutter/codelabs/releases)
- [Commits](flutter/codelabs@fa74033...2adc98c)

---
updated-dependencies:
- dependency-name: examples/codelabs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Thoroughly update and categorize codelabs page (#129)

Add new codelabs and categorize the 'Codelabs & workshops' page.

Co-authored-by: Parker Lougheed <[email protected]>

* Updating info about bitcode (#130)

* Adding a page on false positives from security tools

* Thorough update of the codelabs page.

* Updating bitcode info for iOS

* Incorporating feedback and fixing build

* Revert "Adding a page on false positives from security tools"

This reverts commit cd401f4.

* Revert "Thorough update of the codelabs page."

This reverts commit b79b8d0.

* Removing bitcode image

Co-authored-by: Parker Lougheed <[email protected]>

* Bump examples/codelabs from `2adc98c` to `d48179d` (#131)

Bumps [examples/codelabs](https://github.com/flutter/codelabs) from `2adc98c` to `d48179d`.
- [Release notes](https://github.com/flutter/codelabs/releases)
- [Commits](flutter/codelabs@2adc98c...d48179d)

---
updated-dependencies:
- dependency-name: examples/codelabs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pigeon in /examples/development/platform_integration (#132)

Bumps [pigeon](https://github.com/flutter/packages/tree/main/packages) from 6.0.3 to 7.0.0.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/pigeon-v7.0.0/packages)

---
updated-dependencies:
- dependency-name: pigeon
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Documents new web initialization config. (#133)

* Document new web initialization.

* Attempt to correctly render tables in github.

* Fix table definition (3 cols)

* Apply suggestions from code review

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

* Bump examples/codelabs from `d48179d` to `967b87a` (#137)

* Bump jekyll from 4.3.1 to 4.3.2 (#139)

Bumps [jekyll](https://github.com/jekyll/jekyll) from 4.3.1 to 4.3.2.
- [Release notes](https://github.com/jekyll/jekyll/releases)
- [Changelog](https://github.com/jekyll/jekyll/blob/master/History.markdown)
- [Commits](jekyll/jekyll@v4.3.1...v4.3.2)

---
updated-dependencies:
- dependency-name: jekyll
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump jekyll-toc from 0.17.1 to 0.18.0 (#138)

Bumps [jekyll-toc](https://github.com/toshimaru/jekyll-toc) from 0.17.1 to 0.18.0.
- [Release notes](https://github.com/toshimaru/jekyll-toc/releases)
- [Commits](toshimaru/jekyll-toc@v0.17.1...v0.18.0)

---
updated-dependencies:
- dependency-name: jekyll-toc
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Background isolate channels (#140)

* Updated the platform channels documentation to show how to use plugins and platform channels from background isolate.

* Update src/development/platform-integration/platform-channels.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

* Add a blockquote style for new 'Security false positives' page (#141)

* Add a new check_link_references exception for release notes (#142)

* Add a new check_link_references exception

* Adjust code comments

* Remove release notes used for testing

* Use full code block for 'Testing accessibility on web' command (#143)

This allows for syntax highlighting and easy copying of the command.

* updating the Whats new in 3.7 page (#134)

* Updating for the 3.7 release

* Adding another update

* Fixing a typo

* Updating the what's new page for 3.7

* Fix unclosed comment

* Fix Impeller GitHub Wiki link reference

Co-authored-by: Parker Lougheed <[email protected]>

* 3.7.0 release notes (#136)

* [WIP] 3.7.0 release notes

* Update medium link

Update medium link to include flutter 3.7

* Fix broken medium link

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>

* News toolkit page (#135)

* Stashing the in-progress news toolkit page

* Stashing the news toolkit page

* Tweaking, as per Zoey's instructions

* Fix toolkit docs link reference

Co-authored-by: Parker Lougheed <[email protected]>

* Update the videos page (#144)

* Adding a page on false positives from security tools

* Thorough update of the codelabs page.

* Stashing changes until I get more info

* Update the videos page for 3.7

* Remove sidenav change

* Delete security-false-positives.md

* link learning to fly s2e1

Co-authored-by: Khanh Nguyen <[email protected]>

* Bump examples/codelabs from `967b87a` to `a6b830b` (#145)

* Updating banner to check to livestream (#147)

* Removing unpublished articles (#146)

* Bump flutter from `135454a` to `b06b8b2` (#148)

Bumps [flutter](https://github.com/flutter/flutter) from `135454a` to `b06b8b2`.
- [Release notes](https://github.com/flutter/flutter/releases)
- [Commits](flutter/flutter@135454a...b06b8b2)

---
updated-dependencies:
- dependency-name: flutter
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix build.yml

* Remove Python from CodeQL analysis

* Remove extra branch specifiers from link check workflow

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: John Ryan <[email protected]>
Co-authored-by: Khanh Nguyen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Loïc Sharma <[email protected]>
Co-authored-by: Loic Sharma <[email protected]>
Co-authored-by: Mitchell Goodwin <[email protected]>
Co-authored-by: Anthony Sansone <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: David Iglesias <[email protected]>
Co-authored-by: gaaclarke <[email protected]>
Co-authored-by: Kevin Chisholm <[email protected]>
Co-authored-by: Khanh Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@appsforartists @abarth @sethladd @krisgiesing