-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Makefile] Impossible to setup on Windows #8272
Comments
Also, copying Flutter from the host will cause platform issues that unable to start any Flutter commands.
Lines 27 to 28 in 5494bf1
|
@AlexV525 : Your second issue is a Windows Git issue. Check out this StackOverflow post that explains the issue. TL;DR: Git translated UNIX line breaks to Windows line breaks on
That ensured that all writes to git and GitHub use LF only.
This ensures that all reads to git and GitHub use LF only. A deeper dive can be found on this GitHub page. |
Closing as duplicate of #6443. |
It's unfriendly to ask users to reconfigure their global configurations if they're not unnecessary, like Git, if the step can be done to solve them externally. |
_Description of what this PR is changing or adding, and why:_ The PR removes the `flutter` repo as a submodule to avoid conflicts when building the website on different platforms. It was first introduced in #1257 but with no explanation so we cannot track back what's the purpose, but removing this should not cause difficulties in maintaining the website. ### Additional info - The build process is slower than the previous one because the checkout step needs an extra 3~5 minutes, depending on the network condition. See [now](https://github.com/flutter/website/actions/runs/5985413443/job/16237673762?pr=9307) and [previous](https://github.com/flutter/website/actions/runs/5983398408/job/16237673076?pr=9298) checks. _Issues fixed (partially) by this PR (if any):_ - #6201 - #6443 - #8272 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Anthony Sansone <[email protected]> Co-authored-by: Parker Lougheed <[email protected]>
`time` is not a valid command on Windows. This helps to setup the environment on the Windows platform. We currently not monitoring the built time so we can add it back once we have requests. Issues fixed (partially) by this PR: - flutter#6443 - flutter#8272
_Description of what this PR is changing or adding, and why:_ The PR removes the `flutter` repo as a submodule to avoid conflicts when building the website on different platforms. It was first introduced in flutter#1257 but with no explanation so we cannot track back what's the purpose, but removing this should not cause difficulties in maintaining the website. ### Additional info - The build process is slower than the previous one because the checkout step needs an extra 3~5 minutes, depending on the network condition. See [now](https://github.com/flutter/website/actions/runs/5985413443/job/16237673762?pr=9307) and [previous](https://github.com/flutter/website/actions/runs/5983398408/job/16237673076?pr=9298) checks. _Issues fixed (partially) by this PR (if any):_ - flutter#6201 - flutter#6443 - flutter#8272 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Anthony Sansone <[email protected]> Co-authored-by: Parker Lougheed <[email protected]>
_Description of what this PR is changing or adding, and why:_ The PR removes the `flutter` repo as a submodule to avoid conflicts when building the website on different platforms. It was first introduced in #1257 but with no explanation so we cannot track back what's the purpose, but removing this should not cause difficulties in maintaining the website. ### Additional info - The build process is slower than the previous one because the checkout step needs an extra 3~5 minutes, depending on the network condition. See [now](https://github.com/flutter/website/actions/runs/5985413443/job/16237673762?pr=9307) and [previous](https://github.com/flutter/website/actions/runs/5983398408/job/16237673076?pr=9298) checks. _Issues fixed (partially) by this PR (if any):_ - #6201 - #6443 - #8272 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Anthony Sansone <[email protected]> Co-authored-by: Parker Lougheed <[email protected]>
Describe the problem
website/Makefile
Lines 172 to 173 in 5494bf1
Since most of the commands start with
clean
, there is no way to runrm
on Windows command lines.Expected fix
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: