This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add matthew-carroll to reviewers #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @collinjackson Matt has volunteered to help with maintenance and reviews for these plugins. |
CODEOWNERS
Outdated
| packages/camera/* @bparrishMines @mklim | ||
| packages/connectivity/* @cyanglaz | ||
| packages/connectivity/* @matthew-carroll |
There was a problem hiding this comment.
It seems more common (and consistent with elsewhere in this file) to put all the CODEOWNERS on one line per pattern. See this example:
https://github.com/python/cpython/blob/master/.github/CODEOWNERS
There was a problem hiding this comment.
Ok, I placed names on single lines and I also added consistent spacing to more easily read the names like the file you linked.
collinjackson
approved these changes
Feb 13, 2020
|
LGTM! Thanks. |
|
@amirh @collinjackson should this PR wait to go green to merge? Or we can go ahead and merge given the non-functional changes? |
|
Merged, thanks! |
sanekyy
pushed a commit
to sanekyy/plugins
that referenced
this pull request
Feb 18, 2020
* Add matthew-carroll to reviewers
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
* Add matthew-carroll to reviewers
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* Add matthew-carroll to reviewers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add matthew-carroll to reviewers