[camera] Camera web mobile orientation #6976
Open
+88
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logic and remove null assertions and memory allocations.
…ation, so we get a portrait stream when the phone is oriented as a portrait. This doesn't update the orientation, but at least we get the expected stream to start with.
…of cover, as the cover showed a "zoomed-in" version of the camera feed
kristoffer-zliide
force-pushed
the
camera-web-mobile-orientation
branch
from
9f3c674
to
92a3244
Compare
… as the height/width of the camera was already correct
kristoffer-zliide
force-pushed
the
camera-web-mobile-orientation
branch
from
92a3244
to
d2dba71
Compare
|
From triage: ping @ditman and @bparrishMines on this review. |
| @@ -172,6 +172,8 @@ class CameraValue { | |||
| CameraDescription? description, | |||
| Optional<DeviceOrientation>? previewPauseOrientation, | |||
| }) { | |||
| assert((isRecordingVideo ?? false) == | |||
There was a problem hiding this comment.
Is this assert in copyWith necessary? This is used by other methods to freely change state, so I don't think we should be asserting anything here. Potentially this check is better in the method that changes it.
| if (kIsWeb || defaultTargetPlatform != TargetPlatform.android) { | ||
| return child; | ||
| if (defaultTargetPlatform == TargetPlatform.android) { | ||
| if (kIsWeb) { |
There was a problem hiding this comment.
Doesn't this only check if the app was compiled for web?: https://api.flutter.dev/flutter/foundation/kIsWeb-constant.html
This should cause this to always be false if defaultTargetPlatform == TargetPlatform.android is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various orientation-related fixes for camera in mobile browsers, including flutter/flutter#143288 and flutter/flutter#117430. The improved video constraints might also fix the zoom behavior observed in flutter/flutter#112280. Previously closed as #6362.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).