[flutter_adaptive_scaffold] Allows for the animation duration to be adjusted using SlotLayout.from() #6510

oravecz-jpmc · 2024-04-12T16:10:15Z

Added duration to the SlotLayoutConfig constructor and from() method. This allows a user to specify the duration of the in/out animations which they can already supply.

The default animation of 1 second is nice for demos where a slowed down animation helps to show the behavior, but it is (arguably?) way too slow for an application where one wants a snappy animation effect.

List which issues are fixed by this PR. You must list at least one issue.

Fixes flutter/flutter#112938

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

No change to tests

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-04-12T16:10:19Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

…pacts the animation speed

oravecz-jpmc · 2024-04-12T19:08:32Z

Added test case to ensure animation duration is being applied

gspencergoog

stuartmorgan · 2024-05-24T17:12:25Z

packages/flutter_adaptive_scaffold/lib/src/slot_layout.dart

@@ -160,6 +163,9 @@ class SlotLayoutConfig extends StatelessWidget {
 /// as the returned widget.
 final Widget Function(Widget, Animation<double>)? outAnimation;

+ /// The amount of time taken by the execution of the in and out animations


This comment is missing the period at the end.

stuartmorgan · 2024-05-24T17:13:11Z

packages/flutter_adaptive_scaffold/test/adaptive_layout_test.dart

+ expect(begin, findsOneWidget);
+ expect(end, findsNothing);
+
+ // expand in 1/5 second


Please format all comments as sentences, with capitalization and punctuation (applies here and below).

stuartmorgan · 2024-05-24T17:14:19Z

packages/flutter_adaptive_scaffold/test/adaptive_layout_test.dart

@@ -415,7 +435,7 @@ AnimatedWidget leftInOut(Widget child, Animation<double> animation) {
 );
 }

-MediaQuery slot(double width, WidgetTester tester) {
+MediaQuery slot(double width, int durationMs, WidgetTester tester) {


Why is this an int with the type in the name rather than a Duration that would directly encode unit information in the code?

stuartmorgan · 2024-06-04T19:56:10Z

@oravecz-jpmc Is this ready for re-review?

oravecz-jpmc · 2024-06-24T15:18:26Z

Yes, ready for re-review. I adjusted the format of comments as requested.

stuartmorgan

This isn't passing CI, including analyze; that will need to be resolved before re-review.

stuartmorgan · 2024-06-24T15:25:07Z

packages/flutter_adaptive_scaffold/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.1.11+1


I missed that the version change itself was lost from the PR, which is part of why CI is failing.

…on to be adjusted using SlotLayout.from() (flutter/packages#6510)

flutter/packages@711b4ac...03f5f6d 2024-06-24 [email protected] [interactive_media_ads] Fix README badge image URL (flutter/packages#6979) 2024-06-24 [email protected] [multicast_dns] Optimized Socket Binding: Always bind to 0.0.0.0 for simplicity and efficiency - #79772 (flutter/packages#6700) 2024-06-24 [email protected] [flutter_adaptive_scaffold] Allows for the animation duration to be adjusted using SlotLayout.from() (flutter/packages#6510) 2024-06-22 [email protected] [in_app_purchase_storekit] Remove OCMock (flutter/packages#6862) 2024-06-22 [email protected] [google_maps_flutter] Add iOS SDK 9.x support (flutter/packages#6902) 2024-06-21 [email protected] [google_maps_flutter] Partial Android host API Pigeon conversion (flutter/packages#6967) 2024-06-21 [email protected] Revert "Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`." (flutter/packages#6964) 2024-06-21 [email protected] [quick_actions] Update to Pigeon 20 (flutter/packages#6961) 2024-06-20 [email protected] [google_maps_flutter] Move Android inspector to Pigeon (flutter/packages#6958) 2024-06-20 [email protected] Manual roll Flutter from ccf3abe to 6c06abb (21 revisions) (flutter/packages#6954) 2024-06-20 [email protected] [many] More v1 embedding deletion that was missed in flutter/packages#6494 (flutter/packages#6923) 2024-06-20 [email protected] [google_maps_flutter] deprecate old BitmapDescriptor methods (flutter/packages#6905) 2024-06-18 [email protected] [pigeon] Fully-qualify types in Equatable extension test (flutter/packages#6946) 2024-06-18 [email protected] [flutter_markdown] fixes null check operator used on null value if onSelectionChanged isâ�¦ (flutter/packages#6883) 2024-06-17 [email protected] Roll Flutter from 5187cab to ccf3abe (6 revisions) (flutter/packages#6940) 2024-06-17 [email protected] [google_sign_in_web] README.md typo (flutter/packages#6642) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 32.0.1-android to 33.2.1-android and CameraX version to 1.3.4 in /packages/camera/camera_android_camerax/android (flutter/packages#6847) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 32.0.1-android to 33.2.1-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#6846) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [quick_actions]: Bump com.android.tools.build:gradle from 7.2.1 to 8.4.1 in /packages/quick_actions/quick_actions_android/android (flutter/packages#6799) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/path_provider/path_provider_android/android (flutter/packages#6773) 2024-06-17 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/camera/camera_android/android (flutter/packages#6766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

oravecz-jpmc added 2 commits April 12, 2024 11:49

Allows for the animation duration to be adjusted using SlotLayout.from()

c8ab2d4

Updated the pubspec and changelog according to PR requirements

ac390ee

oravecz-jpmc requested a review from gspencergoog as a code owner April 12, 2024 16:10

github-actions bot added the p: flutter_adaptive_scaffold label Apr 12, 2024

oravecz-jpmc added 2 commits April 12, 2024 15:03

Added tests to ensure the animation duration can be configured and im…

4d7259c

…pacts the animation speed

Merge remote-tracking branch 'upstream/main'

b41dbf1

Merge branch 'main' into main

0d069aa

gspencergoog approved these changes Apr 26, 2024

View reviewed changes

stuartmorgan self-requested a review May 21, 2024 19:51

stuartmorgan requested changes May 24, 2024

View reviewed changes

Made requested changes from the PR

c1d0f3c

Merge branch 'main' into main

1c4742a

stuartmorgan approved these changes Jun 24, 2024

View reviewed changes

stuartmorgan requested changes Jun 24, 2024

View reviewed changes

oravecz-jpmc added 2 commits June 24, 2024 13:20

Ensuring tests and analyze pass. Using 0.1.11+1 as new version number

f5da939

Fixed file formatting

d49bb8b

oravecz-jpmc requested a review from stuartmorgan June 24, 2024 17:58

stuartmorgan approved these changes Jun 24, 2024

View reviewed changes

stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2024

auto-submit bot merged commit fdb78fc into flutter:main Jun 24, 2024
74 checks passed

engine-flutter-autoroll mentioned this pull request Jun 24, 2024

Roll Packages from 711b4ac2794e to fdb78fcbd55d (19 revisions) flutter/flutter#150711

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2024

fdb78fcbd [flutter_adaptive_scaffold] Allows for the animation durati…

7d1d612

…on to be adjusted using SlotLayout.from() (flutter/packages#6510)

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Packages from 711b4ac2794e to 03f5f6d5660c (21 revisions) flutter/flutter#150779

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2024

fdb78fcbd [flutter_adaptive_scaffold] Allows for the animation durati…

57e2417

…on to be adjusted using SlotLayout.from() (flutter/packages#6510)

reidbaker mentioned this pull request Jul 2, 2024

i151188 update espresso dependencies v2 reidbaker/packages#6

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_adaptive_scaffold] Allows for the animation duration to be adjusted using SlotLayout.from() #6510

[flutter_adaptive_scaffold] Allows for the animation duration to be adjusted using SlotLayout.from() #6510

oravecz-jpmc commented Apr 12, 2024

flutter-dashboard bot commented Apr 12, 2024

oravecz-jpmc commented Apr 12, 2024

gspencergoog left a comment

stuartmorgan May 24, 2024

stuartmorgan May 24, 2024

stuartmorgan May 24, 2024

stuartmorgan commented Jun 4, 2024

oravecz-jpmc commented Jun 24, 2024

stuartmorgan left a comment

stuartmorgan Jun 24, 2024

[flutter_adaptive_scaffold] Allows for the animation duration to be adjusted using SlotLayout.from() #6510

[flutter_adaptive_scaffold] Allows for the animation duration to be adjusted using SlotLayout.from() #6510

Conversation

oravecz-jpmc commented Apr 12, 2024

Pre-launch Checklist

flutter-dashboard bot commented Apr 12, 2024

oravecz-jpmc commented Apr 12, 2024

gspencergoog left a comment

Choose a reason for hiding this comment

stuartmorgan May 24, 2024

Choose a reason for hiding this comment

stuartmorgan May 24, 2024

Choose a reason for hiding this comment

stuartmorgan May 24, 2024

Choose a reason for hiding this comment

stuartmorgan commented Jun 4, 2024

oravecz-jpmc commented Jun 24, 2024

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan Jun 24, 2024

Choose a reason for hiding this comment