[Re-land] Upgrade Android SDK to 34 "UpsideDownCake" #47839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4' into upgrade_to_android14
8 tasks
zanderso
approved these changes
Nov 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 9, 2023
…138166) flutter/engine@eb89b94...ca30d7d 2023-11-09 [email protected] Roll Skia from 775da2d297de to a58076ed871a (3 revisions) (flutter/engine#47866) 2023-11-09 [email protected] [Re-land] Upgrade Android SDK to 34 "UpsideDownCake" (flutter/engine#47839) 2023-11-09 [email protected] Roll Dart SDK from 6bd98dc2dffd to 33307e78db2b (1 revision) (flutter/engine#47865) 2023-11-09 [email protected] Use specific version of mac_toolchain (flutter/engine#47835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
8 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2023
Update Android SDK from 33 to 34. Following the engine update: * flutter/engine#47839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between this PR and the original is the change to the
AndroidManifest.xml. For context, right before the original PR landed, a change to upgrade the target sdk in the manifest from 31 to 33 landed. It also removed the lint complaining about using an old target sdk version from the baseline lint file. So this change upgrading the sdk, but not the target sdk in the manifest, triggered the lint again.For the rest of the PR, see the description of the original PR.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.