Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Copy uniforms before appending them to the DisplayList #36981

Merged
merged 5 commits into from
Oct 25, 2022
Merged

[Impeller] Copy uniforms before appending them to the DisplayList #36981

merged 5 commits into from
Oct 25, 2022

Conversation

bdero
Copy link
Member

@bdero bdero commented Oct 24, 2022 •
edited
Loading

ReusableFragmentShader has a lifetime that lasts longer than a frame, and the uniforms can be continually changed on the UI thread. So take a copy (intention immutable) of the uniforms before handing it to the DL for consumption on the render thread.

@bdero bdero self-assigned this Oct 24, 2022
jonahwilliams
jonahwilliams approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zanderso
zanderso approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bdero bdero merged commit 7acf886 into flutter:main Oct 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 25, 2022
@engine-flutter-autoroll
7acf886f6 [Impeller] Copy uniforms before appending them to the Displ…
d7393d8 
…ayList (flutter/engine#36981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

@bdero bdero

Labels
e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
3 participants
@bdero @zanderso @jonahwilliams