Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[canvaskit] Make the context current before disposing it #36671

Conversation

harryterkelsen
Copy link
Contributor

When we delete a Surface context (for example because it has resized) we must make sure that it is the current context or Skia might throw an exception while deleting resources associated with that context.

Fixes flutter/flutter#91881

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Oct 7, 2022
@harryterkelsen harryterkelsen requested review from ditman and mdebbar and removed request for ditman October 7, 2022 23:55
@ditman
Copy link
Member

ditman commented Oct 20, 2022

Do we still want to land this?

@harryterkelsen
Copy link
Contributor Author

Do we still want to land this?

Yes. For some reason I thought I already landed it

@harryterkelsen harryterkelsen merged commit e4bd0b1 into flutter:main Oct 21, 2022
@ditman
Copy link
Member

ditman commented Oct 21, 2022

Thanks @hterkelsen!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web][canvaskit] Images Disappear after leaving Fullscreen
3 participants