Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Add missing Vector3 arithmetic ops #36373

Merged
merged 1 commit into from
Sep 23, 2022
Merged

[Impeller] Add missing Vector3 arithmetic ops #36373

merged 1 commit into from
Sep 23, 2022

Conversation

bdero
Copy link
Member

@bdero bdero commented Sep 23, 2022

  • Adds Vector3 *= scale, Vector3 /= scale, Vector3 * Vector3, Vector3 * scale, Vector3 / Vector3, Vector3 / scale.
  • Covers all existing/new arithmetic ops in tests.
  • Fixes bug in scale / Vector3.

@bdero bdero self-assigned this Sep 23, 2022
@bdero bdero merged commit 41d9b96 into flutter:main Sep 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 23, 2022
@engine-flutter-autoroll
41d9b96e6 Add missing arithmetic ops to Vector3 (flutter/engine#36373)
d963a6c
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@bdero @OlehSv
Add missing arithmetic ops to Vector3 (flutter#36373)
82cdf79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

@bdero bdero

Labels
e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
2 participants
@bdero @zanderso