Update editing state in InputConnectionAdaptor.setSelection #17652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
reviewed
Apr 11, 2020
| @@ -286,7 +286,7 @@ private boolean isSamsung() { | |||
| @Override | |||
| public boolean setSelection(int start, int end) { | |||
| boolean result = super.setSelection(start, end); | |||
| markDirty(); | |||
| updateEditingState(); | |||
There was a problem hiding this comment.
The markDirty() should be called as well before the updateEditingState() to make sure it is not accidentally treated as a repeat call.
GaryQian
approved these changes
Apr 11, 2020
The BaseInputConnection superclass does not call endBatchEdit in setSelection and therefore does not implicitly cause InputConnectionAdaptor to send a state update. Some input modes such as numeric keypads will not function without these updates.
11db00c
to
467219b
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2020
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 12, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…17652) The BaseInputConnection superclass does not call endBatchEdit in setSelection and therefore does not implicitly cause InputConnectionAdaptor to send a state update. Some input modes such as numeric keypads will not function without these updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BaseInputConnection superclass does not call endBatchEdit
in setSelection and therefore does not implicitly cause
InputConnectionAdaptor to send a state update.
Some input modes such as numeric keypads will not function without
these updates.