Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom widgets to legend slider #1233

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented Apr 30, 2023

Connection with issue(s)

Close #1207

Solution description

  • Add custom widgets to slider
  • Add dart docs

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #1233 (53d9ab6) into main (76a1074) will decrease coverage by 0.13%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   86.15%   86.03%   -0.13%     
==========================================
  Files          20       20              
  Lines         715      716       +1     
==========================================
  Hits          616      616              
- Misses         99      100       +1     
Impacted Files Coverage Δ
lib/src/fields/form_builder_range_slider.dart 97.05% <ø> (ø)
lib/src/fields/form_builder_slider.dart 97.05% <85.71%> (-2.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 81c3b97 into main Apr 30, 2023
@deandreamatias deandreamatias deleted the feature-1207 branch April 30, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do you format a formslider to have accompanying text?
1 participant