Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical: Update Deprecated 'new-flake' Method Rename in bootstrap.clj (#213) #219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Domenic-MZS
Copy link

@Domenic-MZS Domenic-MZS commented Nov 23, 2023

🔧 Critical: Update Deprecated 'new-flake' Method Rename in bootstrap.clj (#213)

This pull request closes issue #213 opened by @anujsrc.

Overview

The issue highlights a build failure in the Ledger main branch due to an unimplemented deprecated function reference (flake/new-flake).

  • Issue: Compiling errors due to fluree/db breaking changes on the last update, causing a critical compile error.
  • Context: The method flake/new-flake which was previously deprecated, was recently renamed to flake/create causing a critical error when compiling the code.
  • Solutions: This is the first pull request trying to solve this specific problem by updating the method name.
  • Impact: By addressing the renamed method the critical error will no longer stop the compilation process, making an important improvement to all users and developers.

📓 Description

This pull request resolves the deprecated method from the bootstrap.clj introduced on fluree/db@e02c152 by updating the method name to flake/create.

✍🏼 Changes Made

  • bootstrap.clj
    • renamed deprecated method from flake/new-flake to flake/create
// Replaced deprecated flake/new-flake with flake/create as per issue #213
- (flake/new-flake ...  )
+ (flake/create      ...  )

🦯 Testing

  • Update Tests (ToDo - Not Found)
  • Compile/Build code (tested on version 2.0.4 with Ubuntu)

Notes & References

Reviewers

@bplatz


Hi this is one of my firsts Pull Requests over here, any feedback, changes or suggestions are welcome!

Replaces all matching references of `flake/new-flake` -> `flake/create` on
`bootstrap.clj`as it was fully deprecated on fluree/db@e02c152 with breaking
changes.
@Domenic-MZS Domenic-MZS changed the title Fix: Replace Deprecated flake/new-flake with flake/create in Ledger Bootstrap (#213) Critical: Resolve 'new-flake' Deprecation in bootstrap.clj for Compiling Error (#213) Nov 28, 2023
@Domenic-MZS Domenic-MZS changed the title Critical: Resolve 'new-flake' Deprecation in bootstrap.clj for Compiling Error (#213) Critical: Update Deprecated 'new-flake' Method Rename in bootstrap.clj (#213) Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant