Use correct leaderboard data #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluofoxxo
reviewed
Dec 2, 2019
| loginTime := player.LastLogin | ||
| mainCharaID := player.PlayerState.MainCharaID | ||
| mainCharaLevel := int64(12) // TODO: remove testing | ||
| mainCharaLevel := player.CharacterState[0].Level // TODO: is this right? |
There was a problem hiding this comment.
This is incorrect. The main character is fetched by getting the index of the main character by player.PlayerState.MainCharaID. The player struct has a helper function for this: player.IndexOfChara(player.PlayerState.MainCharaID).
Likewise, this applies to line 26, and lines 28 and 30 with player.IndexOfChao(player.PlayerState.MainChaoID).
|
Newest commit looks good, will test a build soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects some issues found on the continue screen, as well as showing the timed mode high score instead of the story mode high score on the timed mode results screen.