-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1820 api authorization with roles #1846
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added it to service and presentation layer
…siness logic rather that database logic
…ew ClientId model
…nitilize happens
Refactored the `ApiToken` class to replace `Token` and `ExpiredAt` with `Key`, `Secret`, and `ExpireAt`. Removed `ApiKey` property. Replaced `ApiTokenProvider` with a new HMACSHA256-based implementation. Updated `ApiTokenService` to use new methods, added `RegenerateSecret` and `Validate` methods. Simplified `PolicyAttribute` by removing `Microsoft.AspNetCore.Authorization` dependency. Removed `Constants` class. Updated controllers to use `PolicyAll` attribute. Updated `PolicyAuthorizeFilter` to use `X-API-AUTH` header and new `ApiTokenService` methods. Updated `IApiTokenRepository` and implementations to use `Key` property. Added new exception codes for token issues. Added `JwtApiTokenProvider` and updated `IApiTokenProvider` interface.
Reformatted code in ApiTokenProvider.cs and RoleController.cs to improve readability and maintain consistent formatting. Removed an unnecessary blank line in ApiTokenRepository.cs. No functional changes were made.
- Modify `Update` method in `ApiTokenController` to use `mapper` for mapping `ApiTokenUpdateRequest` to `ApiToken`. - Update `apiTokenService.Update` to accept `ApiToken` and `CancellationToken`. - Add mapping configuration in `MappingProfile` for `ApiTokenUpdateRequest` to `ApiToken`. - Replace `Token` and `ExpiredAt` with `Key`, `Secret`, and `ExpireAt` in `ApiTokenDetailResponse`. - Include `ExpireAt` and reorder `Description` in `ApiTokenUpdateRequest`.
Updated GeneratedApiClients.cs to use newer versions of NSwag (14.1.0.0) and NJsonSchema (11.0.2.0). Introduced instance-specific JsonSerializerOptions for flexible serialization settings. Added Initialize method in constructors and partial methods for customization. Updated pragma directives and renamed classes/properties for consistency. Renamed FileUploadConfiguration to FileUploadConfig in multiple files. Updated labels in ApiTokenListPlugin.razor and fixed formatting in SingleFileFieldFormFilePicker.razor.cs.
Introduced `ConfigManager` and `IConfigManager` for improved configuration handling. Updated `SetupManager` to initialize the database and API token using the new configuration system. Removed `ConfigurationExtensions` class and its methods. Updated `ApiClientServiceExtensions` to use `ApiSettings` configuration. Modified `appsettings.json` to reflect the new configuration structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.